Resolves Issue #1856 and #1857: Return authority validation errors for invalid registry org roles#1859
Merged
Conversation
jdaigneau5
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1856 and #1857
Summary
This MR fixes registry organization validation so invalid
authorityvalues return structured errors instead of producing an uninformativeParameters were invalidresponse. It also prevents mixed authority arrays from reaching the joint-approval review-object flow with invalidBaseOrgdata.Important Changes
src/repositories/baseOrgRepository.jsauthorityarray item before discriminator-specific validation mutates the authority value.instancePath, message, and allowed values.['cna']or['CNA', {}, null, 1234, true]from reachingupdateOrgFull()and review-object creation.test/integration-tests/registry-org/registryOrgCRUDTest.jsPUT /api/registry/org/:shortnamewith lowercaseauthority: ['cna']./authority/0and an allowed-values validation message.Testing
Steps to manually test updated functionality, if possible
bash -i -c "npm run test:integration".