fix: use release start timestamp for delta zip filename#130
Open
enriqueesanchz wants to merge 1 commit into
Open
fix: use release start timestamp for delta zip filename#130enriqueesanchz wants to merge 1 commit into
enriqueesanchz wants to merge 1 commit into
Conversation
The delta zip filename was derived from new Date() inside DeltaCommand.run(), which captures the time when the function executes rather than when the release started. If processing crosses an hour boundary the filename ends up one hour ahead of the release tag (e.g. tag cve_2026-01-29_0200Z contains a file named 2026-01-29_delta_CVEs_at_0300Z.zip). Fixes CVEProject#124
Author
|
Can you please review? @hkong-mitre @rbrittonMitre @jdaigneau5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delta zip filename was derived from new Date() inside DeltaCommand.run(), which captures the time when the function executes rather than when the release started.
If processing crosses an hour boundary the filename ends up one hour ahead of the release tag (e.g. tag cve_2026-01-29_0200Z contains a file named 2026-01-29_delta_CVEs_at_0300Z.zip).
Fixes #124