tweak(gamemessage): Remove unused argument of MSG_DESTROY_SELECTED_GROUP (TheSuperHackers#2664)

Author: Caball009

Generals/Code/GameEngine/Include/Common/MessageStream.h

@@ -472,7 +472,7 @@ class GameMessage : public MemoryPoolObject
 																									* The selected team is created/augmented with the given team members.
 																									* Do not play their selection sounds.
 																									*/
-		MSG_DESTROY_SELECTED_GROUP,									///< (teamID) the given team is no longer valid
+		MSG_DESTROY_SELECTED_GROUP,									///< deselect currently selected objects (which can be none)
 		MSG_REMOVE_FROM_SELECTED_GROUP,							/**< (objectID1, objectID2, ... objectIDN)
 																									* Remove these units from the selected group. (N should almost always be 1)
 																									*/

Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp

@@ -3493,10 +3493,8 @@ void InGameUI::deselectAllDrawables( Bool postMsg )
 	the order of operations of things happening in the code (CBD) */
 	if( postMsg )
 	{
-		GameMessage *groupMsg = TheMessageStream->appendMessage( GameMessage::MSG_DESTROY_SELECTED_GROUP );
-
-		//True deletes entire group.
-		groupMsg->appendBooleanArgument( true );
+		// TheSuperHackers @tweak Originally this message had one boolean argument, but it wasn't used for anything.
+		TheMessageStream->appendMessage( GameMessage::MSG_DESTROY_SELECTED_GROUP );
 	}
 }
 

GeneralsMD/Code/GameEngine/Include/Common/MessageStream.h

@@ -503,7 +503,7 @@ class GameMessage : public MemoryPoolObject
 																									* The selected team is created/augmented with the given team members.
 																									* Do not play their selection sounds.
 																									*/
-		MSG_DESTROY_SELECTED_GROUP,									///< (teamID) the given team is no longer valid
+		MSG_DESTROY_SELECTED_GROUP,									///< deselect currently selected objects (which can be none)
 		MSG_REMOVE_FROM_SELECTED_GROUP,							/**< (objectID1, objectID2, ... objectIDN)
 																									* Remove these units from the selected group. (N should almost always be 1)
 																									*/

GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp

@@ -3584,10 +3584,8 @@ void InGameUI::deselectAllDrawables( Bool postMsg )
 	the order of operations of things happening in the code (CBD) */
 	if( postMsg )
 	{
-		GameMessage *groupMsg = TheMessageStream->appendMessage( GameMessage::MSG_DESTROY_SELECTED_GROUP );
-
-		//True deletes entire group.
-		groupMsg->appendBooleanArgument( true );
+		// TheSuperHackers @tweak Originally this message had one boolean argument, but it wasn't used for anything.
+		TheMessageStream->appendMessage( GameMessage::MSG_DESTROY_SELECTED_GROUP );
 	}
 }