Skip to content

Commit e57abc9

Browse files
committed
Let the script figure out OS and arch
1 parent 0af25b3 commit e57abc9

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/main.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ jobs:
5454

5555
- name: Test python/qt combinations
5656
uses: coactions/setup-xvfb@v1
57-
env:
58-
GITHUB_MATRIX_OS: ${{ matrix.os }}
5957
with:
6058
run: bash scripts/test-matrix.sh
6159

scripts/test-matrix.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ set -euo pipefail
44

55
PYTHON_VERSIONS=("3.8" "3.9" "3.10" "3.11" "3.12" "3.13")
66
QT_VERSIONS=("pyside2" "pyside6" "pyqt5" "pyqt6")
7-
OS_NAME="${GITHUB_MATRIX_OS:-$(uname | tr '[:upper:]' '[:lower:]')}"
7+
TARGET_OS="${GITHUB_MATRIX_OS:-$(uname | tr '[:upper:]' '[:lower:]')}"
8+
TARGET_ARCH="${GITHUB_MATRIX_ARCH:-$(uname -m)}"
89

910
TEST_MATRIX=()
1011
for PY in "${PYTHON_VERSIONS[@]}"; do
@@ -13,8 +14,8 @@ for PY in "${PYTHON_VERSIONS[@]}"; do
1314
echo "$QT skipping $PY (requires <3.11)"
1415
continue
1516
fi
16-
if [[ "$QT" == "pyside2" && "$OS_NAME" == "darwin" && "$(uname -m)" == "arm64" ]]; then
17-
echo "$QT skipping $OS_NAME (does not publish arm64 packages)"
17+
if [[ "$QT" == "pyside2" && "$TARGET_OS" == "darwin" && "$TARGET_ARCH" == "arm64" ]]; then
18+
echo "$QT skipping $TARGET_OS (does not publish arm64 packages)"
1819
continue
1920
fi
2021
if [[ "$QT" == "pyside6" || "$QT" == "pyqt6" ]] && [[ "$PY" == "3.8" ]]; then
@@ -23,7 +24,7 @@ for PY in "${PYTHON_VERSIONS[@]}"; do
2324
fi
2425

2526
export VIRTUAL_ENV=".venvs/$PY-$QT"
26-
echo "Preparing $VIRTUAL_ENV"
27+
echo "Preparing $VIRTUAL_ENV "
2728
uv venv --clear --no-config --no-project --python "$PY" "$VIRTUAL_ENV"
2829

2930
echo "Installing qasync dependencies to $VIRTUAL_ENV"

0 commit comments

Comments
 (0)