Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
src/qasync
__init__.py
_common.py
_windows.py
Project Total

This report was generated by python-coverage-comment-action

After looking at this up close, we loose all the static typing by doing getattr and import_module. For example my LSP (pyright with ruff) can figure out that I have a Qt library available in my venv, thus one of the imports is not marked as an error and I get types and autocomplete for free. Which is not the case when using the changes proposed here.

While verbose, it helps to have the typing info while working with the code. I would like to move towards adding typing as suggested in #124.

@hosaka Could you please take another look at this? Thanks!

@johnzhou721 Sorry I've neglected this for a bit. I think this doesn't add much value to be frank. The env_to_mod_map is being covered now with the coverage aggregated across all test variations since 57a7e2a

I feel at this point that peppering more "no cover" is not of much use. I am going to close this for now, if you you'd like to improve the test coverage and have spare time, feel free to PR changes that address this.