Skip to content

PKGBUILD: add "clang" mode and rename _use_llvm_lto to _use_llvm #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptr1337 wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −17
Open

PKGBUILD: add "clang" mode and rename _use_llvm_lto to _use_llvm #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions linux-cachyos/PKGBUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,14 @@
# - "generic" (kernel's default - to share the package between machines with different CPU µarch as long as they are x86-64)
: "${_processor_opt:=}"

# Clang LTO mode, only available with the "llvm" compiler - options are "none", "full" or "thin".
# ATTENTION - one of three predefined values should be selected!
# "full: uses 1 thread for Linking, slow and uses more memory, theoretically with the highest performance gains."
# "thin: uses multiple threads, faster and uses less memory, may have a lower runtime performance than Full."
# "thin-dist: Similar to thin, but uses a distributed model rather than in-process: https://discourse.llvm.org/t/rfc-distributed-thinlto-build-for-kernel/85934"
# "none: disable LTO
: "${_use_llvm_lto:=thin}"
# Compiler and LTO selection - options are "none", "clang", "thin", "thin-dist" or "full".
# ATTENTION - one of the predefined values should be selected!
# "none": use GCC with LTO disabled.
# "clang": use Clang as compiler but with LTO disabled.
# "thin": use Clang with ThinLTO - multiple threads, faster and uses less memory, may have a lower runtime performance than Full.
# "thin-dist": use Clang with distributed ThinLTO - https://discourse.llvm.org/t/rfc-distributed-thinlto-build-for-kernel/85934
# "full": use Clang with Full LTO - 1 thread for Linking, slow and uses more memory, theoretically with the highest performance gains.
: "${_use_llvm:=thin}"
Copy link
Copy Markdown
Member

@1Naim 1Naim Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to replace "none" and "clang" to "no" and "yes" respectively to match the other config options?

Copy link
Copy Markdown
Member Author

@ptr1337 ptr1337 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require then another variable for clang = no/yes and then which kind of lto mode?

Copy link
Copy Markdown
Member

@1Naim 1Naim Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just keep it all-in-one.

So instead of none, clang, thin, full, etc. There's no, yes, thin, full, etc.


# Use suffix -lto only when requested by the user
# yes - enable -lto suffix
Expand Down Expand Up @@ -151,7 +152,12 @@

# ATTENTION: Do not modify after this line
_is_lto_kernel() {
[[ "$_use_llvm_lto" = "thin" || "$_use_llvm_lto" = "full" || "$_use_llvm_lto" = "thin-dist" ]]
[[ "$_use_llvm" = "thin" || "$_use_llvm" = "full" || "$_use_llvm" = "thin-dist" ]]
return $?
}

_is_clang_build() {
Copy link
Copy Markdown
Member Author

@ptr1337 ptr1337 Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly added this for the QR Code check

_is_lto_kernel || [[ "$_use_llvm" = "clang" ]]
Comment on lines +155 to +160
Copy link
Copy Markdown
Member

@1Naim 1Naim Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[ "$_use_llvm" = "thin" || "$_use_llvm" = "full" || "$_use_llvm" = "thin-dist" ]]
return $?
}
_is_clang_build() {
_is_lto_kernel || [[ "$_use_llvm" = "clang" ]]
_is_clang_build() {
[[ "$_use_llvm" != "none" ]]
}
is_lto_kernel {
is_clang_build && [[ "$_use_llvm" != "clang" ]]
}

Just a slight nitpick. Either works.

return $?
}

Expand All @@ -162,7 +168,7 @@ _is_ci_build() {

if _is_lto_kernel && [ "$_use_lto_suffix" = "yes" ]; then
_pkgsuffix=cachyos-lto
elif ! _is_lto_kernel && [ "$_use_gcc_suffix" = "yes" ]; then
elif ! _is_clang_build && [ "$_use_gcc_suffix" = "yes" ]; then
_pkgsuffix=cachyos-gcc
else
_pkgsuffix=cachyos
Expand Down Expand Up @@ -213,7 +219,7 @@ source=(
"config")

# LLVM makedepends
if _is_lto_kernel; then
if _is_clang_build; then
makedepends+=(clang llvm lld)
source+=("${_patchsource}/misc/dkms-clang.patch")
BUILD_FLAGS=(
Expand Down Expand Up @@ -341,18 +347,18 @@ prepare() {
fi

### Select LLVM level
case "$_use_llvm_lto" in
case "$_use_llvm" in
thin) scripts/config -e LTO_CLANG_THIN;;
thin-dist) scripts/config -e LTO_CLANG_THIN_DIST;;
full) scripts/config -e LTO_CLANG_FULL;;
none) scripts/config -e LTO_NONE;;
*) _die "The value '$_use_llvm_lto' is invalid. Choose the correct one again.";;
clang|none) scripts/config -e LTO_NONE;;
*) _die "The value '$_use_llvm' is invalid. Choose the correct one again.";;
esac

echo "Selecting '$_use_llvm_lto' LLVM level..."
echo "Selecting '$_use_llvm' LLVM level..."

if ! _is_lto_kernel; then
echo "Enabling QR Code Panic for GCC Kernels"
echo "Enabling QR Code Panic for non-LTO Kernels"
scripts/config --set-str DRM_PANIC_SCREEN qr_code -e DRM_PANIC_SCREEN_QR_CODE \
--set-str DRM_PANIC_SCREEN_QR_CODE_URL https://panic.archlinux.org/panic_report# \
--set-val CONFIG_DRM_PANIC_SCREEN_QR_VERSION 40
Expand Down Expand Up @@ -531,7 +537,7 @@ _sign_modules() {
local sign_cert="${srcdir}/${_srcname}/certs/signing_key.x509"
local hash_algo="$(grep -Po 'CONFIG_MODULE_SIG_HASH="\K[^"]*' "${srcdir}/${_srcname}/.config")"

if [ "$_use_llvm_lto" != "none" ]; then
if [ "$_use_llvm" != "none" ]; then
local strip_bin="llvm-strip"
else
local strip_bin="strip"
Expand Down Expand Up @@ -567,7 +573,7 @@ build() {
cd ${srcdir}/"zfs"

local CONFIGURE_FLAGS=()
[ "$_use_llvm_lto" != "none" ] && CONFIGURE_FLAGS+=("KERNEL_LLVM=1")
[ "$_use_llvm" != "none" ] && CONFIGURE_FLAGS+=("KERNEL_LLVM=1")

./autogen.sh
sed -i "s|\$(uname -r)|${_kernuname}|g" configure
Expand Down Expand Up @@ -626,6 +632,8 @@ _package-headers() {
if _is_lto_kernel; then
provides+=(linux-cachyos-lto-headers=$_kernver)
replaces=(linux-cachyos-lto-headers)
fi
if _is_clang_build; then
depends+=(clang llvm lld)
fi

Expand Down