Resolving Issue #27

cigamit · cigamit · commit 4017be74e448 · 2019-07-24T21:47:06.000-05:00
Deprecated functions and legacy path causing issues with schedules
diff --git a/README.md b/README.md
@@ -44,6 +44,7 @@ Got any ideas or complaints, please see the Cacti forums or GitHub for a resolut
 
 --- develop ---
 
+* issue#27: Deprecated functions and legacy path causing issues with schedules
 * issue#28: Flowview filters not searchable using some international characters
 
 --- 2.1 ---
diff --git a/flowview_devices.php b/flowview_devices.php
@@ -219,7 +219,7 @@ function actions_devices () {
 	$i = 0;
 
 	/* loop through each of the devices selected on the previous page and get more info about them */
-	while (list($var,$val) = each($_POST)) {
+	foreach($_POST as $var => $val) {
 		if (preg_match('/^chk_([0-9]+)$/', $var, $matches)) {
 			/* ================= input validation ================= */
 			input_validate_input_number($matches[1]);
diff --git a/flowview_schedules.php b/flowview_schedules.php
@@ -163,7 +163,7 @@ function actions_schedules () {
 	$schedule_list = '';
 
 	/* loop through each of the devices selected on the previous page and get more info about them */
-	while (list($var,$val) = each($_POST)) {
+	foreach($_POST as $var => $val) {
 		if (preg_match('/^chk_([0-9]+)$/', $var, $matches)) {
 			/* ================= input validation ================= */
 			input_validate_input_number($matches[1]);
diff --git a/functions.php b/functions.php
@@ -247,7 +247,7 @@ function flowview_display_report() {
 			is: function(s) {
 				return false;
 			},
-        
+
 			format: function(s) {
 				if (s.indexOf('MB') > 0) {
 					loc=s.indexOf('MB');
@@ -361,7 +361,7 @@ function plugin_flowview_run_schedule($id) {
 
 	$message  = "<body style='margin:10px;'>";
 	$message .= "<style type='text/css'>\n";
-	$message .= file_get_contents($config['base_path'] . '/include/main.css');
+	$message .= file_get_contents($config['base_path'] . '/include/themes/modern/main.css');
 	$message .= '</style>';
 	$sessionid = -1;
 	$message .= createfilter($sessionid);
