Stop PRINT_REDIRECTOR from outliving the LogViewer

PRINT_REDIRECTOR is a module-level singleton, so the lambda connected to
sigStdoutWrite in prepare_panes accumulated one connection per MainWindow and
was never disconnected. Each lambda also closed over self and resolved
self.components["log"] late through a dict that MainMixin holds as a class
attribute, so it reached whichever LogViewer registered last. Once a LogViewer
was destroyed, the next print() called into a deleted C++ object and raised
RuntimeError.

Connecting the bound method instead lets PyQt drop the connection when the
receiver is destroyed.

Author: markomarkovic

cq_editor/main_window.py

@@ -291,9 +291,11 @@ def prepare_panes(self):
         for d in self.docks.values():
             d.show()
 
-        PRINT_REDIRECTOR.sigStdoutWrite.connect(
-            lambda text: self.components["log"].append(text)
-        )
+        # Connect the bound method rather than a lambda: PRINT_REDIRECTOR is a
+        # module-level singleton, and PyQt drops a connection to a QObject's
+        # bound method when that QObject is destroyed. A lambda would outlive
+        # the LogViewer and call into a deleted C++ object.
+        PRINT_REDIRECTOR.sigStdoutWrite.connect(self.components["log"].append)
 
     def prepare_menubar(self):
 

tests/test_app.py

@@ -14,8 +14,10 @@
 from PyQt5.QtCore import Qt, QSettings, QPoint, QEvent, QSize
 from PyQt5.QtWidgets import QFileDialog, QMessageBox
 from PyQt5.QtGui import QMouseEvent
+from PyQt5 import sip
 
 from cq_editor.__main__ import MainWindow
+from cq_editor.main_window import PRINT_REDIRECTOR
 from cq_editor.widgets.editor import Editor
 from cq_editor.cq_utils import export, get_occ_color
 
@@ -2202,3 +2204,33 @@ def test_editor_autoreload(editor):
 #     with qtbot.waitSignal(editor.triggerRerender, timeout=TIMEOUT):
 #         # modify file - NB: separate process is needed to avoid Windows quirks
 #         modify_file(code_nested_bottom, "test_nested_bottom.py")
+
+
+def test_print_redirector_released_with_window(qtbot, mocker):
+    """
+    PRINT_REDIRECTOR is a module-level singleton that outlives any MainWindow.
+    Its connection to a window's LogViewer must be released when that window is
+    destroyed; otherwise a later write reaches a deleted C++ object and raises
+    "wrapped C/C++ object of type LogViewer has been deleted".
+    """
+
+    mocker.patch.object(QMessageBox, "question", return_value=QMessageBox.Yes)
+    mocker.patch.object(QMessageBox, "warning", return_value=QMessageBox.Discard)
+
+    win = MainWindow()
+    qtbot.addWidget(win)
+
+    # destroy this window's LogViewer, as tearing the window down would
+    sip.delete(win.components["log"])
+
+    # PyQt routes an exception raised inside a slot to sys.excepthook rather
+    # than propagating it, so capture it there while emitting
+    errors = []
+    original_hook = sys.excepthook
+    sys.excepthook = lambda exc_type, *rest: errors.append(exc_type)
+    try:
+        PRINT_REDIRECTOR.sigStdoutWrite.emit("stray output after close")
+    finally:
+        sys.excepthook = original_hook
+
+    assert errors == []