Skip to content

Commit ad5cb92

Browse files
fix: Allow duplicate sub-assemblies
1 parent 2e05819 commit ad5cb92

File tree

2 files changed

+2
-9
lines changed

2 files changed

+2
-9
lines changed

cadquery/assembly.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,8 @@ def add(self, arg, **kwargs):
244244
# enforce unique names
245245
name = kwargs["name"] if kwargs.get("name") else arg.name
246246
if name in self.objects:
247-
raise ValueError(
248-
f"Unique name is required. {name} is already in the assembly"
249-
)
247+
# Add a incremented number to the name
248+
name = f"{name}_{len(self.objects)}"
250249

251250
subassy = arg._copy()
252251

tests/test_assembly.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1792,12 +1792,6 @@ def test_constrain_with_tags(nested_assy):
17921792
nested_assy.constrain("SECOND/BOTTOM ? pts", "dummy", "Plane")
17931793

17941794

1795-
def test_duplicate_name(nested_assy):
1796-
1797-
with pytest.raises(ValueError):
1798-
nested_assy.add(None, name="SECOND")
1799-
1800-
18011795
def test_empty_solve(nested_assy):
18021796

18031797
with pytest.raises(ValueError):

0 commit comments

Comments
 (0)