Skip to content

Commit 3569ca3

Browse files
refactor: simplify ToProvider method calls and adjust project warnings
Removed unnecessary type parameters in `ToProvider` method calls across tests for improved readability. Added EF Core warning suppression (`EF1001`) in the PostgreSQL test project. Cleaned up unused `using` directives in tests.
1 parent 291325e commit 3569ca3

5 files changed

Lines changed: 6 additions & 9 deletions

File tree

CodoMetis.ValueRanges.EFCore.PostgreSQL.Tests/CodoMetis.ValueRanges.EFCore.PostgreSQL.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<ImplicitUsings>enable</ImplicitUsings>
66
<Nullable>enable</Nullable>
77
<IsPackable>false</IsPackable>
8-
<NoWarn>$(NoWarn);1591</NoWarn>
8+
<NoWarn>$(NoWarn);1591;EF1001</NoWarn>
99
</PropertyGroup>
1010

1111
<ItemGroup>

CodoMetis.ValueRanges.EFCore.PostgreSQL.Tests/ProviderConversionTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,22 +79,22 @@ public void RoundTrip_Int64_Finite()
7979
[TestMethod]
8080
public void ToProvider_Empty_MapsToNpgsqlEmpty()
8181
{
82-
var provider = RangeProviderConversion.ToProvider<DateOnly>(DateRange.Empty, null);
82+
var provider = RangeProviderConversion.ToProvider(DateRange.Empty, null);
8383
Assert.IsTrue(provider.IsEmpty);
8484
}
8585

8686
[TestMethod]
8787
public void ToProvider_Infinity_MapsToDoublyInfinite()
8888
{
89-
var provider = RangeProviderConversion.ToProvider<DateOnly>(DateRange.Infinite, null);
89+
var provider = RangeProviderConversion.ToProvider(DateRange.Infinite, null);
9090
Assert.IsTrue(provider.LowerBoundInfinite);
9191
Assert.IsTrue(provider.UpperBoundInfinite);
9292
}
9393

9494
[TestMethod]
9595
public void ToProvider_DiscreteFinite_IsFullyClosed()
9696
{
97-
var provider = RangeProviderConversion.ToProvider<DateOnly>(
97+
var provider = RangeProviderConversion.ToProvider(
9898
DateRange.CreateFinite(new DateOnly(2024, 1, 1), new DateOnly(2024, 3, 31)), null);
9999
Assert.IsTrue(provider.LowerBoundIsInclusive);
100100
Assert.IsTrue(provider.UpperBoundIsInclusive);
@@ -123,7 +123,7 @@ public void ToProvider_NormalizesDateTimeKind()
123123
new DateTime(2024, 1, 1, 10, 0, 0, DateTimeKind.Utc),
124124
new DateTime(2024, 1, 1, 12, 0, 0, DateTimeKind.Local));
125125

126-
var provider = RangeProviderConversion.ToProvider<DateTime>(
126+
var provider = RangeProviderConversion.ToProvider(
127127
range, value => DateTime.SpecifyKind(value, DateTimeKind.Unspecified));
128128

129129
Assert.AreEqual(DateTimeKind.Unspecified, provider.LowerBound.Kind);
@@ -137,7 +137,7 @@ public void ToProvider_NormalizesDateTimeOffsetToUtc()
137137
new DateTimeOffset(2024, 1, 1, 10, 0, 0, TimeSpan.FromHours(2)),
138138
new DateTimeOffset(2024, 1, 1, 12, 0, 0, TimeSpan.FromHours(2)));
139139

140-
var provider = RangeProviderConversion.ToProvider<DateTimeOffset>(range, value => value.ToUniversalTime());
140+
var provider = RangeProviderConversion.ToProvider(range, value => value.ToUniversalTime());
141141

142142
Assert.AreEqual(TimeSpan.Zero, provider.LowerBound.Offset);
143143
Assert.AreEqual(new DateTimeOffset(2024, 1, 1, 8, 0, 0, TimeSpan.Zero), provider.LowerBound);

CodoMetis.ValueRanges.Tests/RangeJsonConverterTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Text.Json;
2-
using CodoMetis.ValueRanges;
32
using CodoMetis.ValueRanges.Serialization;
43

54
namespace CodoMetis.ValueRanges.Tests;

CodoMetis.ValueRanges.Tests/RangeParseFormatTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Globalization;
2-
using CodoMetis.ValueRanges;
32

43
namespace CodoMetis.ValueRanges.Tests;
54

CodoMetis.ValueRanges.Tests/RangeSetParseFormatTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Globalization;
2-
using CodoMetis.ValueRanges;
32

43
namespace CodoMetis.ValueRanges.Tests;
54

0 commit comments

Comments
 (0)