New extension TableMethodThrowTypeExtension

Author: rochamarcelo

src/ThrowType/TableMethodThrowTypeExtension.php

@@ -20,6 +20,19 @@ class TableMethodThrowTypeExtension implements DynamicMethodThrowTypeExtension
      */
     protected ReflectionProvider $reflectionProvider;
 
+    /**
+     * @var array<int, string>
+     */
+    protected array $methods = [
+        'get',
+        'deleteManyOrFail',
+        'findOrCreate',
+        'save',
+        'saveOrFail',
+        'saveMany',
+        'saveManyOrFail',
+    ];
+
     /**
      * @param \PHPStan\Reflection\ReflectionProvider $reflectionProvider
      */
@@ -34,7 +47,11 @@ public function __construct(ReflectionProvider $reflectionProvider)
      */
     public function isMethodSupported(MethodReflection $methodReflection): bool
     {
-        return $methodReflection->getName() === 'get';
+        if (!in_array($methodReflection->getName(), $this->methods, true)) {
+            return false;
+        }
+
+        return $methodReflection->getDeclaringClass()->is(Table::class);
     }
 
     /**
@@ -51,8 +68,7 @@ public function getThrowTypeFromMethodCall(
         $methodName = $methodReflection->getName();
         $type = $scope->getType($methodCall->var);
         $classReflection = $type->getObjectClassReflections()[0];
-        $isAssociation = $classReflection->is(Association::class);
-        if ($isAssociation) {
+        if ($classReflection->is(Association::class)) {
             return $this->getThrowType($methodName, $scope);
         }
 

tests/test_app/Controller/NotesController.php

@@ -17,6 +17,8 @@
 use Cake\Datasource\Exception\InvalidPrimaryKeyException;
 use Cake\Datasource\Exception\RecordNotFoundException;
 use Cake\Log\Log;
+use Cake\ORM\Exception\PersistenceFailedException;
+use Cake\ORM\Exception\RolledbackTransactionException;
 use Cake\ORM\TableRegistry;
 
 /**
@@ -197,9 +199,38 @@ public function viewWithTryCatch()
         } catch (RecordNotFoundException) {
         }
 
+        $user = $this->Notes->NewMyUsers->get(1);
         try {
-            $note = $this->Notes->get(1);
-            $note->note = 'This is a test';
+            $this->Notes->NewMyUsers->save($user);
+        } catch (RolledbackTransactionException) {
+        }
+        try {
+            $this->Notes->NewMyUsers->findOrCreate(['name' => 'This is a test']);
+        } catch (PersistenceFailedException) {
+        }
+        try {
+            $this->Notes->NewMyUsers->saveOrFail($user);
+        } catch (PersistenceFailedException) {
+        }
+
+        try {
+            $this->Notes->NewMyUsers->saveMany([$user]);
+        } catch (PersistenceFailedException) {
+        }
+
+        try {
+            $this->Notes->NewMyUsers->saveManyOrFail([$user]);
+        } catch (PersistenceFailedException) {
+        }
+
+        try {
+            $this->Notes->NewMyUsers->deleteManyOrFail([$user]);
+        } catch (PersistenceFailedException) {
+        }
+
+        try {
+            $user = $this->Notes->get(1);
+            $user->note = 'This is a test';
         } catch (InvalidPrimaryKeyException) {
         }
 

tests/test_app/Model/Table/MyUsersTable.php

@@ -7,6 +7,13 @@
 
 /**
  * @method \App\Model\Entity\User get($primaryKey, $options = [])
+ * @method \App\Model\Entity\User findOrCreate($search, ?callable $callback = null, $options = [])
+ * @method \App\Model\Entity\User|false save(\Cake\Datasource\EntityInterface $entity, $options = [])
+ * @method \App\Model\Entity\User saveOrFail(\Cake\Datasource\EntityInterface $entity, $options = [])
+ * @method iterable<\App\Model\Entity\User>|false saveMany(iterable<\App\Model\Entity\User> $entities, $options = [])
+ * @method iterable<\App\Model\Entity\User> saveManyOrFail(iterable<\App\Model\Entity\User> $entities, $options = [])
+ * @method iterable<\App\Model\Entity\User>|false deleteMany(iterable<\App\Model\Entity\User> $entities, $options = [])
+ * @method iterable<\App\Model\Entity\User> deleteManyOrFail(iterable<\App\Model\Entity\User> $entities, $options = [])
  */
 class MyUsersTable extends Table
 {