Updated test_app with better coverage

Author: rochamarcelo

tests/test_app/Controller/NotesController.php

@@ -165,16 +165,21 @@ public function listUsers()
         $this->set(compact('userNamed'));
         $userNamedMary = $this->fetchTable('Users')->findByNamed('Mary')->id;
         $this->set(compact('userNamedMary'));
+        $myUserNamed = $this->Notes->MyUsers->findByNamed('John Doe')->id;//Users is a BelongsTo association
+        $this->set(compact('myUserNamed'));
 
         //UsersTable::findByRole is a magic finder method
         $userList = $this->Notes->Users->findByRole('admin')->all()->toArray();
         $this->set(compact('userList'));
         $userListGuest = $this->fetchTable('Users')->findByRole('guest')->all()->toArray();
         $this->set(compact('userListGuest'));
-        $users = $this->Notes->Users->findAllByFoo(100);
-        foreach ($users as $user) {
-            $user->name = strtolower($user->name);
-        }
+        $myUsersList = $this->Notes->MyUsers->findByRole('admin')->all()->toArray();
+        $this->set(compact('myUsersList'));
+
+        //UsersTable::findAllByFoo exists it is not a magic method
+        $users = $this->Notes->Users->findAllByFoo(100) / 20;
+        $myUsers = $this->Notes->MyUsers->findAllByFoo(100) / 30;
+        $this->set(compact('users', 'myUsers'));
         //BelongsTo should match the correct Users table methods.
         $this->Notes->Users->blockOld();
     }

tests/test_app/Model/Table/NotesTable.php

@@ -21,7 +21,7 @@
  * @method \App\Model\Entity\Note|\Cake\Datasource\EntityInterface get(mixed $primaryKey, string[]|string $finder = 'all',\Psr\SimpleCache\CacheInterface|string|null $cache = null,\Closure|string|null $cacheKey = null, mixed ...$args)
  * @property \App\Model\Table\VeryCustomize00009ArticlesTable&\Cake\ORM\Association\HasMany $VeryCustomize00009Articles
  * @property \Cake\ORM\Association\BelongsTo<\App\Model\Table\UsersTable> $Users
- * @property \Cake\ORM\Association\BelongsTo&\App\Model\Table\UsersTable $MyUsers
+ * @property \Cake\ORM\Association\BelongsTo&\App\Model\Table\UsersTable $MyUsers//Don't use generic here, we need this way for testing
  */
 class NotesTable extends Table
 {

tests/test_app/Model/Table/UsersTable.php

@@ -61,13 +61,10 @@ public function findByNamed(string $name): User
 
     /**
      * @param int $foo
-     * @return list<\App\Model\Entity\User>
+     * @return int
      */
-    public function findAllByFoo(int $foo): array
+    public function findAllByFoo(int $foo): int
     {
-        return [
-            new User(['id' => 'first_' . $foo, 'name' => 'John Doe']),
-            new User(['id' => 'second_' . $foo, 'name' => 'Mary J.']),
-        ];
+        return $foo * 200;
     }
 }