refactor: extract runPhpStan() to PhpStanTestTrait

Author: dereuromark

tests/TestCase/PhpStanTestTrait.php

@@ -0,0 +1,38 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Copyright 2025, Cake Development Corporation (https://www.cakedc.com)
+ *
+ * Licensed under The MIT License
+ * Redistributions of files must retain the above copyright notice.
+ *
+ * @copyright Copyright 2025, Cake Development Corporation (https://www.cakedc.com)
+ * @license   MIT License (http://www.opensource.org/licenses/mit-license.php)
+ */
+
+namespace CakeDC\PHPStan\Test\TestCase;
+
+trait PhpStanTestTrait
+{
+    /**
+     * Run PHPStan on a file and return the output.
+     *
+     * @param string $file File to analyze
+     * @return string
+     */
+    private function runPhpStan(string $file): string
+    {
+        $configFile = dirname(__DIR__, 2) . '/extension.neon';
+        $command = sprintf(
+            'cd %s && vendor/bin/phpstan analyze %s --level=max --configuration=%s --no-progress 2>&1',
+            escapeshellarg(dirname(__DIR__, 2)),
+            escapeshellarg($file),
+            escapeshellarg($configFile),
+        );
+
+        exec($command, $output, $exitCode);
+
+        return implode("\n", $output);
+    }
+}

tests/TestCase/Type/SelectQueryFindListReturnTypeExtensionTest.php

@@ -13,10 +13,12 @@
 
 namespace CakeDC\PHPStan\Test\TestCase\Type;
 
+use CakeDC\PHPStan\Test\TestCase\PhpStanTestTrait;
 use PHPUnit\Framework\TestCase;
 
 class SelectQueryFindListReturnTypeExtensionTest extends TestCase
 {
+    use PhpStanTestTrait;
     /**
      * Test that find('list')->toArray() returns correct type.
      *
@@ -49,25 +51,4 @@ public function testFindListWithGroupFieldReturnsNestedArray(): void
         $output = $this->runPhpStan(__DIR__ . '/Fake/FindListGroupedUsage.php');
         static::assertStringContainsString('[OK] No errors', $output);
     }
-
-    /**
-     * Run PHPStan on a file and return the output.
-     *
-     * @param string $file File to analyze
-     * @return string
-     */
-    private function runPhpStan(string $file): string
-    {
-        $configFile = dirname(__DIR__, 3) . '/extension.neon';
-        $command = sprintf(
-            'cd %s && vendor/bin/phpstan analyze %s --level=max --configuration=%s --no-progress 2>&1',
-            escapeshellarg(dirname(__DIR__, 3)),
-            escapeshellarg($file),
-            escapeshellarg($configFile),
-        );
-
-        exec($command, $output, $exitCode);
-
-        return implode("\n", $output);
-    }
 }

tests/TestCase/Type/TypeFactoryBuildDynamicReturnTypeExtensionTest.php

@@ -13,10 +13,12 @@
 
 namespace CakeDC\PHPStan\Test\TestCase\Type;
 
+use CakeDC\PHPStan\Test\TestCase\PhpStanTestTrait;
 use PHPUnit\Framework\TestCase;
 
 class TypeFactoryBuildDynamicReturnTypeExtensionTest extends TestCase
 {
+    use PhpStanTestTrait;
     /**
      * Test that TypeFactory::build() returns correct types and allows valid method calls.
      *
@@ -43,25 +45,4 @@ public function testTypeFactoryBuildCatchesInvalidMethodCalls(): void
         static::assertStringContainsString('JsonType::nonExistentMethod()', $output);
         static::assertStringContainsString('Found 4 errors', $output);
     }
-
-    /**
-     * Run PHPStan on a file and return the output.
-     *
-     * @param string $file File to analyze
-     * @return string
-     */
-    private function runPhpStan(string $file): string
-    {
-        $configFile = dirname(__DIR__, 3) . '/extension.neon';
-        $command = sprintf(
-            'cd %s && vendor/bin/phpstan analyze %s --level=max --configuration=%s --no-progress 2>&1',
-            escapeshellarg(dirname(__DIR__, 3)),
-            escapeshellarg($file),
-            escapeshellarg($configFile),
-        );
-
-        exec($command, $output, $exitCode);
-
-        return implode("\n", $output);
-    }
 }