Skip to content

Commit 26fdfd6

Browse files
committed
FSM: Fixed uint / int comparison bugs
1 parent ad27d37 commit 26fdfd6

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

include/LoadFSM.hpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ class LoadFSM {
7979
// Check reset conditions
8080
constexpr uint_fast16_t START_RUN_2_RPM = 200; // todo
8181
if ((currentState != FSMCommon::States::sRST) &&
82-
(load.getRPM() <= START_RUN_2_RPM)) { // todo check me!
82+
(load.getRPM() <=
83+
static_cast<int_fast16_t>(START_RUN_2_RPM))) { // todo check me!
8384
// * -> sRST
8485
currentState = FSMCommon::States::sRST;
8586

@@ -92,7 +93,8 @@ class LoadFSM {
9293

9394
return UPDATE_RESULT::STATE_CHANGED;
9495
} else if ((currentState == FSMCommon::States::sRST) &&
95-
load.getRPM() <= START_RUN_2_RPM) {
96+
load.getRPM() <=
97+
static_cast<int_fast16_t>(START_RUN_2_RPM)) {
9698
// sRST -> sRST: Nothing to do
9799
return UPDATE_RESULT::NO_CHANGE;
98100
} else {
@@ -101,7 +103,7 @@ class LoadFSM {
101103
// todo cycling between 2 and 3
102104
// Check other transition conditions
103105
if ((currentState == FSMCommon::States::sRST) &&
104-
(load.getRPM() > START_RUN_2_RPM)) {
106+
(load.getRPM() > static_cast<int_fast16_t>(START_RUN_2_RPM))) {
105107
// sRST -> sStartRun
106108
currentState = FSMCommon::States::sStartRun;
107109

0 commit comments

Comments
 (0)