v1.2.52: Fix backend crash in .exe — add missing hidden imports + error logging to file

CalaKuad1 · CalaKuad1 · commit d3cdf11dc17a · 2026-05-29T16:18:16.000+02:00
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -53,6 +53,8 @@ jobs:
             --collect-all uvicorn \
             --collect-all fastapi \
             --collect-all wsproto \
+            --collect-all requests \
+            --collect-all pydantic \
             --hidden-import=uvicorn.logging \
             --hidden-import=uvicorn.loops \
             --hidden-import=uvicorn.loops.auto \
@@ -63,6 +65,13 @@ jobs:
             --hidden-import=uvicorn.protocols.websockets.auto \
             --hidden-import=uvicorn.lifespan \
             --hidden-import=uvicorn.lifespan.on \
+            --hidden-import=starlette \
+            --hidden-import=starlette.routing \
+            --hidden-import=starlette.middleware \
+            --hidden-import=starlette.requests \
+            --hidden-import=starlette.responses \
+            --hidden-import=multipart \
+            --hidden-import=python_multipart \
             api_server.py
           if [ "${{ matrix.os }}" = "windows-latest" ]; then
             mv dist/api_server.exe .
@@ -136,6 +145,8 @@ jobs:
             --collect-all uvicorn \
             --collect-all fastapi \
             --collect-all wsproto \
+            --collect-all requests \
+            --collect-all pydantic \
             --hidden-import=uvicorn.logging \
             --hidden-import=uvicorn.loops \
             --hidden-import=uvicorn.loops.auto \
@@ -146,6 +157,13 @@ jobs:
             --hidden-import=uvicorn.protocols.websockets.auto \
             --hidden-import=uvicorn.lifespan \
             --hidden-import=uvicorn.lifespan.on \
+            --hidden-import=starlette \
+            --hidden-import=starlette.routing \
+            --hidden-import=starlette.middleware \
+            --hidden-import=starlette.requests \
+            --hidden-import=starlette.responses \
+            --hidden-import=multipart \
+            --hidden-import=python_multipart \
             api_server.py
           if [ "${{ matrix.os }}" = "windows-latest" ]; then
             mv dist/api_server.exe .
diff --git a/backend/api_server.py b/backend/api_server.py
@@ -5,10 +5,11 @@
 # --- CRITICAL: REDIRECT STREAMS IN FROZEN EXE ---
 # If running as a PyInstaller --noconsole EXE, stdout/stderr are None, which crashes many libraries.
 if getattr(sys, "frozen", False) and sys.platform == "win32":
-    null_device = open(os.devnull, "w")
-    sys.stdout = null_device
-    sys.stderr = null_device
-    # Also ensure freeze_support is called as early as possible
+    log_dir = os.path.join(os.getenv("APPDATA", ""), "MinecraftServerGUI")
+    os.makedirs(log_dir, exist_ok=True)
+    log_file = open(os.path.join(log_dir, "backend_crash.log"), "w", encoding="utf-8")
+    sys.stdout = log_file
+    sys.stderr = log_file
     multiprocessing.freeze_support()
 
 import asyncio
diff --git a/backend/server/server_handler.py b/backend/server/server_handler.py
@@ -975,6 +975,9 @@ def delayed_kill():
             player_name = leave_match.group(1)
             self.tracked_players.discard(player_name)
 
+        # Detect common server errors and broadcast structured events
+        self._detect_and_broadcast_errors(line_no_ansi)
+
         clean_line = line_no_ansi.strip()
         suppress_from_console = False
         if clean_line:
@@ -1205,6 +1208,45 @@ def wait_for_stop(self, timeout=30):
             self._log(f"Error while waiting for server to stop: {e}\n", "error")
             return False
 
+    def _detect_and_broadcast_errors(self, line):
+        """Detect common server errors and broadcast structured events."""
+        if not self.output_callback:
+            return
+        error_info = None
+
+        # Mod dependency missing (NoClassDefFoundError)
+        m = re.search(r"NoClassDefFoundError:\s*(\S+)", line)
+        if m:
+            cls = m.group(1)
+            # Map class to mod name
+            error_info = {"type": "server_error", "error": "mod_dependency", "detail": cls}
+            if "geckolib" in cls.lower() or "software.bernie" in cls.lower():
+                error_info["mod"] = "GeckoLib"
+                error_info["fix"] = "Install GeckoLib from the Mods browser"
+            else:
+                error_info["mod"] = cls.split(".")[-1]
+                error_info["fix"] = f"Search and install the mod that provides '{cls}'"
+
+        # Java version error
+        if not error_info and re.search(r"UnsupportedClassVersionError|javax\.net\.ssl", line):
+            error_info = {"type": "server_error", "error": "java_version", "fix": "Update Java to the required version (Settings > System)"}
+
+        # Port conflict
+        if not error_info and re.search(r"Address already in use|BindException", line):
+            error_info = {"type": "server_error", "error": "port_conflict", "fix": "Change the server port in Settings > Network, or close the program using this port"}
+
+        # Out of memory
+        if not error_info and re.search(r"OutOfMemoryError", line):
+            error_info = {"type": "server_error", "error": "out_of_memory", "fix": "Increase RAM allocation in Settings > System > Max RAM"}
+
+        # Mod loading failure
+        if not error_info and re.search(r"Failed to start|LoadingFailedException", line):
+            error_info = {"type": "server_error", "error": "mod_loading", "fix": "Check the console logs for which mod failed, or remove recently added mods"}
+
+        if error_info:
+            error_info["server_id"] = self.server_id
+            self.output_callback(error_info)
+
     def send_command(self, command, silent: bool = False):
         if (
             self.server_process
diff --git a/changelog.txt b/changelog.txt
@@ -2,6 +2,15 @@
 
 ## Version 1.2.5 - 2026-05-28 DNS PROXY, FIXED ADDRESSES & CONSOLE
 
+### CRITICAL FIX:
+- **Fixed backend crash on startup (.exe)** — Added missing hidden imports (`requests`, `pydantic`, `starlette`, `multipart`) to PyInstaller build
+- **Error logging** — Backend crash logs are now saved to `%APPDATA%/MinecraftServerGUI/backend_crash.log`
+
+### ERROR FEEDBACK (NEW):
+- **Server error detection** — Common errors (missing mods, Java version, port conflicts, OOM) are detected and shown as structured error banners with fix suggestions
+- **Mod dependency warnings** — When installing a mod that requires other mods, shows a confirmation dialog
+- **Banner in Dashboard** — Clear, actionable error messages with dismiss button
+
 ### NEW: Fixed Server Addresses (DNS)
 - **Permanent domain** — Each server gets a permanent address like `survival.play.tudominio.app` that never changes
 - **Auto-generated** — Unique subdomain generated automatically from server name + ID (`vanilla-a3f2b`)
diff --git a/electron-app/package.json b/electron-app/package.json
@@ -1,7 +1,7 @@
 {
   "name": "minecraft-server-gui",
   "private": true,
-  "version": "1.2.51",
+  "version": "1.2.52",
   "repository": {
     "type": "git",
     "url": "https://github.com/CalaKuad1/Minecraft-Local-Server-GUI.git"
diff --git a/electron-app/src/components/Dashboard.jsx b/electron-app/src/components/Dashboard.jsx
@@ -435,6 +435,7 @@ export default function Dashboard({ status: serverStatus, onRefresh }) {
     const [dnsSubdomain, setDnsSubdomain] = useState('');
     const [onlineMode, setOnlineMode] = useState(true);
     const [togglingMode, setTogglingMode] = useState(false);
+    const [serverError, setServerError] = useState(null);
 
     const { isConnected, subscribe, send } = useWebSocket();
     const logsEndRef = useRef(null);
@@ -450,6 +451,7 @@ export default function Dashboard({ status: serverStatus, onRefresh }) {
                 isStoppingRef.current = false;
                 if (onRefresh) onRefresh();
             } else if (item.status === 'online') {
+                setServerError(null);
                 if (onRefresh) onRefresh();
             }
             return;
@@ -487,6 +489,11 @@ export default function Dashboard({ status: serverStatus, onRefresh }) {
             return;
         }
 
+        if (item.type === 'server_error') {
+            setServerError(item);
+            return;
+        }
+
         if (item.message !== undefined || item.level) {
             const msgText = typeof item.message === 'string' ? item.message : JSON.stringify(item.message || '');
 
@@ -731,6 +738,37 @@ export default function Dashboard({ status: serverStatus, onRefresh }) {
                     </div>
                 </div>
 
+            {/* Error Banner */}
+            {serverError && (
+                <div className="rounded-sm border border-red-500/20 bg-red-500/5 p-4 relative overflow-hidden">
+                    <div className="flex items-start gap-3">
+                        <div className="p-1.5 rounded-sm bg-red-500/10 text-red-400 shrink-0 mt-0.5">
+                            <svg width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2"><circle cx="12" cy="12" r="10"/><line x1="12" y1="8" x2="12" y2="12"/><line x1="12" y1="16" x2="12.01" y2="16"/></svg>
+                        </div>
+                        <div className="flex-1 min-w-0">
+                            <div className="text-xs font-minecraft tracking-wider uppercase text-red-400 mb-0.5">
+                                {serverError.error === 'mod_dependency' ? 'Missing Mod Dependency' :
+                                 serverError.error === 'java_version' ? 'Java Version Error' :
+                                 serverError.error === 'port_conflict' ? 'Port Conflict' :
+                                 serverError.error === 'out_of_memory' ? 'Out of Memory' :
+                                 serverError.error === 'mod_loading' ? 'Mod Loading Error' :
+                                 'Server Error'}
+                            </div>
+                            <div className="text-[11px] text-zinc-400 leading-relaxed">
+                                {serverError.fix || 'Unknown error. Check the console for details.'}
+                                {serverError.mod && <span className="text-zinc-500 ml-1">— {serverError.mod}</span>}
+                            </div>
+                            <div className="text-[9px] text-zinc-600 font-mono mt-1 truncate">{serverError.detail}</div>
+                        </div>
+                        <button onClick={() => setServerError(null)} className="p-1 rounded-sm text-zinc-500 hover:text-white hover:bg-white/5 transition-colors shrink-0">
+                            <svg width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2"><line x1="18" y1="6" x2="6" y2="18"/><line x1="6" y1="6" x2="18" y2="18"/></svg>
+                        </button>
+                    </div>
+                    {/* Dismiss hint */}
+                    <div className="absolute bottom-0 left-0 right-0 h-8 bg-gradient-to-t from-red-500/[0.02] to-transparent pointer-events-none"></div>
+                </div>
+            )}
+
             {/* Tunnel Section */}
             <div className="p-4 bg-[#18181b]/60 border border-white/5 rounded-sm relative z-50 backdrop-blur-2xl">
                 <div className="flex items-center gap-4">
diff --git a/electron-app/src/components/Mods.jsx b/electron-app/src/components/Mods.jsx
@@ -87,37 +87,29 @@ export default function Mods({ status, onOpenWizard }) {
     };
 
     const handleInstall = async (mod) => {
-        // Find best version if we can, or just install what we have? 
-        // NOTE: 'mod' here is a search result. It has 'project_id' or 'slug'.
-        // We actually need a SPECIFIC FILE VERSION ID. 
-        // The search result usually contains `latest_version` string or we should hit `getModVersions`.
-        //
-        // FOR NOW: Let's assume we fetch versions first to be safe, OR if the search result allows direct install (unlikely).
-        // Modrinth Search Result -> slug.
-
-        // 1. Fetch versions
-        // 2. Install latest compatible
-
         try {
-            setInstalling(prev => ({ ...prev, [mod.slug]: true })); // Use slug as key
+            setInstalling(prev => ({ ...prev, [mod.slug]: true }));
 
-            // Fetch versions
             const versions = await api.getModVersions(mod.slug, activeLoader, activeVersion);
             if (!versions || versions.length === 0) {
-                // Try fetching "any" version just in case filters were too strict
-                // Or just error
                 throw new Error("No compatible versions found for this server.");
             }
 
-            const targetVersion = versions[0]; // First one is usually latest
+            const targetVersion = versions[0];
 
-            // Trigger install
-            // The backend now runs async and sends WS progress
-            await api.installMod(targetVersion.id);
+            // Check for required dependencies
+            const reqDeps = targetVersion.dependencies?.filter(d => d.dependency_type === 'required') || [];
+            if (reqDeps.length > 0) {
+                const depNames = reqDeps.map(d => d.project_id).join(', ');
+                const proceed = await dialog.confirm(
+                    `${mod.title || mod.slug} requires ${reqDeps.length} mod${reqDeps.length > 1 ? 's' : ''}.\n\nRequired: ${reqDeps.map(d => d.file_name || d.project_id).join(', ')}\n\nInstall ${mod.title || mod.slug} anyway? (Dependencies must be installed separately)`,
+                    "Required Dependencies",
+                    { variant: "warning", confirmLabel: "Install Anyway", cancelLabel: "Cancel" }
+                );
+                if (!proceed) { setInstalling(prev => ({ ...prev, [mod.slug]: false })); return; }
+            }
 
-            // We don't await completion here anymore, we watch WS.
-            // But we can keep state 'installing' until we get a completion event?
-            // For now, let's rely on standard WS logs or optimistically say "Started".
+            await api.installMod(targetVersion.id);
 
         } catch (err) {
             console.error(err);

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "minecraft-server-gui",`
`3`	`3`	`"private": true,`
`4`		`- "version": "1.2.51",`
	`4`	`+ "version": "1.2.52",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
`7`	`7`	`"url": "https://github.com/CalaKuad1/Minecraft-Local-Server-GUI.git"`