Skip to content

Commit f9fb783

Browse files
committed
fix: resolve stop button hang by removing stdin.close() and fix players tab crash by safely accessing cached_status
1 parent a982810 commit f9fb783

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

backend/server/server_handler.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -909,14 +909,6 @@ def stop(self, silent=False, force=False):
909909
self._log("Attempting graceful stop...\n", "info")
910910
self.send_command("stop")
911911

912-
# Cerrar stdin para señalar EOF (Fin de Archivo).
913-
# Esto ayuda a que Java sepa que la consola se ha cerrado y termine antes.
914-
try:
915-
if self.server_process and self.server_process.stdin:
916-
self.server_process.stdin.close()
917-
except Exception as e:
918-
self._log(f"Warning closing stdin: {e}\n", "warning")
919-
920912
# Lanzar un hilo para vigilar si se cuelga
921913
threading.Thread(target=self._watchdog_stop, daemon=True).start()
922914

@@ -1383,5 +1375,7 @@ def get_active_players_list(self, trigger_refresh: bool = True):
13831375
# Fallback: Use SLP sample (may be empty)
13841376
self._update_status_cache()
13851377
if self.cached_status and self.cached_status.get("online"):
1386-
return self.cached_status["players"]["sample"] or []
1378+
players_data = self.cached_status.get("players", {})
1379+
if players_data:
1380+
return players_data.get("sample") or []
13871381
return []

0 commit comments

Comments
 (0)