Skip to content

Commit cc06c62

Browse files
AchtuurCalcProgrammer1
authored andcommitted
Rename Setting RunZoneChecks -> run_zone_checks
1 parent b4ca000 commit cc06c62

2 files changed

Lines changed: 20 additions & 5 deletions

File tree

qt/OpenRGBSettingsPage/OpenRGBSettingsPage.cpp

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,24 @@ OpenRGBSettingsPage::OpenRGBSettingsPage(QWidget *parent) :
139139
}
140140
}
141141

142+
/*-------------------------------------*\
143+
| Use PascalCase key for compatibility |
144+
| should be removed later on. |
145+
\*-------------------------------------*/
142146
if(ui_settings.contains("RunZoneChecks"))
143147
{
144-
ui->CheckboxRunZoneChecks->setChecked(ui_settings["RunZoneChecks"]);
148+
/*----------------------------------*\
149+
| Migrate key to snake_case version |
150+
\*----------------------------------*/
151+
ui_settings["run_zone_checks"] = ui_settings["RunZoneChecks"];
152+
ui_settings.erase("RunZoneChecks");
153+
ResourceManager::get()->GetSettingsManager()->SetSettings("UserInterface", ui_settings);
154+
155+
ui->CheckboxRunZoneChecks->setChecked(ui_settings["run_zone_checks"]);
156+
}
157+
else if (ui_settings.contains("run_zone_checks"))
158+
{
159+
ui->CheckboxRunZoneChecks->setChecked(ui_settings["run_zone_checks"]);
145160
}
146161
else
147162
{
@@ -579,7 +594,7 @@ void OpenRGBSettingsPage::on_CheckboxSaveGeometry_clicked()
579594
void OpenRGBSettingsPage::on_CheckboxRunZoneChecks_clicked()
580595
{
581596
json ui_settings = ResourceManager::get()->GetSettingsManager()->GetSettings("UserInterface");
582-
ui_settings["RunZoneChecks"] = ui->CheckboxRunZoneChecks->isChecked();
597+
ui_settings["run_zone_checks"] = ui->CheckboxRunZoneChecks->isChecked();
583598
ResourceManager::get()->GetSettingsManager()->SetSettings("UserInterface", ui_settings);
584599
SaveSettings();
585600
}

qt/OpenRGBZonesBulkResizer/OpenRGBZonesBulkResizer.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ void OpenRGBZonesBulkResizer::RunChecks(QWidget *parent)
2727
SettingsManager* settings_manager = ResourceManager::get()->GetSettingsManager();
2828
json ui_settings = settings_manager->GetSettings("UserInterface");
2929

30-
if(!ui_settings.is_null() && ui_settings.contains("RunZoneChecks"))
30+
if(!ui_settings.is_null() && ui_settings.contains("run_zone_checks"))
3131
{
32-
json run_zone_checks = ui_settings["RunZoneChecks"];
32+
json run_zone_checks = ui_settings["run_zone_checks"];
3333

3434
if(!run_zone_checks.is_null() && run_zone_checks.is_boolean())
3535
{
@@ -233,7 +233,7 @@ void OpenRGBZonesBulkResizer::SaveDoNotRunState()
233233

234234
bool state = ui->do_not_show_again_checkbox->checkState() == Qt::Checked;
235235

236-
ui_settings["RunZoneChecks"] = !state;
236+
ui_settings["run_zone_checks"] = !state;
237237

238238
settings_manager->SetSettings("UserInterface", ui_settings);
239239
settings_manager->SaveSettings();

0 commit comments

Comments
 (0)