Skip to content

Commit 33f03ac

Browse files
committed
Drop unused time import, add tests for calculate_end_of_backfill_range
1 parent b369b67 commit 33f03ac

2 files changed

Lines changed: 25 additions & 1 deletion

File tree

amiadapters/storage/snowflake.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from abc import ABC, abstractmethod
2-
from datetime import datetime, time
2+
from datetime import datetime
33
import logging
44
from typing import List, Set
55

test/amiadapters/storage/test_snowflake.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,3 +472,27 @@ def test_verify_no_duplicate_reads_and_return_oldest_flowtime_finds_oldest_flowt
472472
reads[1].flowtime,
473473
oldest_flowtime,
474474
)
475+
476+
def test_calculate_end_of_backfill_range__returns_min_flowtime(self):
477+
expected_min = datetime.datetime(2024, 11, 29, 19, 0, tzinfo=pytz.UTC)
478+
self.mock_cursor.execute.return_value.fetchall.return_value = [(expected_min,)]
479+
480+
result = self.snowflake_sink.calculate_end_of_backfill_range(
481+
"some_org",
482+
datetime.datetime(2023, 1, 1),
483+
datetime.datetime(2026, 4, 23),
484+
)
485+
486+
self.assertEqual(expected_min, result)
487+
488+
def test_calculate_end_of_backfill_range__returns_max_date_when_no_readings(self):
489+
max_date = datetime.datetime(2026, 4, 23)
490+
self.mock_cursor.execute.return_value.fetchall.return_value = [(None,)]
491+
492+
result = self.snowflake_sink.calculate_end_of_backfill_range(
493+
"some_org",
494+
datetime.datetime(2023, 1, 1),
495+
max_date,
496+
)
497+
498+
self.assertEqual(max_date, result)

0 commit comments

Comments
 (0)