fix: some "\" in paths not escaped

Calvin-LL · Calvin-LL · commit d2310d4f2a0c · 2021-04-30T22:29:24.000-07:00
diff --git a/src/helpers/getRequireStringWithModifiedResizeLoaderOptions.ts b/src/helpers/getRequireStringWithModifiedResizeLoaderOptions.ts
@@ -54,15 +54,14 @@ export default async function getRequireStringWithModifiedResizeLoaderOptions(
         )
       )
     );
-  const newRequestString = remainingRequest.replace(
-    resizeLoaderRequest,
-    newResizeLoaderQuery
-  );
+  const newRequestString = remainingRequest
+    .replace(resizeLoaderRequest, newResizeLoaderQuery)
+    .replace(/\\/g, "\\\\");
 
   return newRequestString;
 }
 
 // needed so webpack doesn't mistake "!" for query operator "!"
 function escapeJsonStringForLoader(s: string): string {
-  return s.replace(/!/g, "\\\\x21").replace(/\\n/g, "\\\\n");
+  return s.replace(/!/g, "\\x21");
 }

Original file line number	Diff line number	Diff line change
`@@ -54,15 +54,14 @@ export default async function getRequireStringWithModifiedResizeLoaderOptions(`
`54`	`54`	`)`
`55`	`55`	`)`
`56`	`56`	`);`
`57`		`- const newRequestString = remainingRequest.replace(`
`58`		`- resizeLoaderRequest,`
`59`		`- newResizeLoaderQuery`
`60`		`- );`
	`57`	`+ const newRequestString = remainingRequest`
	`58`	`+ .replace(resizeLoaderRequest, newResizeLoaderQuery)`
	`59`	`+ .replace(/\\/g, "\\\\");`
`61`	`60`
`62`	`61`	`return newRequestString;`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`// needed so webpack doesn't mistake "!" for query operator "!"`
`66`	`65`	`function escapeJsonStringForLoader(s: string): string {`
`67`		`- return s.replace(/!/g, "\\\\x21").replace(/\\n/g, "\\\\n");`
	`66`	`+ return s.replace(/!/g, "\\x21");`
`68`	`67`	`}`