Skip to content

Commit 3938fb4

Browse files
committed
Update windows private cmake
1 parent f0b40dd commit 3938fb4

3 files changed

Lines changed: 18 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,12 @@ endif()
198198
# Compiler warnings and definitions
199199
if(MSVC)
200200
target_compile_options(databricks_sdk PRIVATE /W4)
201-
target_compile_definitions(databricks_sdk PRIVATE NOMINMAX)
201+
target_compile_definitions(databricks_sdk
202+
PRIVATE
203+
NOMINMAX # Prevent min/max macros
204+
NOGDI # Prevent GDI macros (including ERROR)
205+
WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
206+
)
202207
else()
203208
target_compile_options(databricks_sdk PRIVATE -Wall -Wextra -Wpedantic)
204209
endif()

examples/CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@ target_link_libraries(secrets_example PRIVATE databricks_sdk)
2424
if(MSVC)
2525
set(ALL_EXAMPLES simple_query jobs_example compute_example unity_catalog_example secrets_example)
2626
foreach(example ${ALL_EXAMPLES})
27-
target_compile_definitions(${example} PRIVATE NOMINMAX)
27+
target_compile_definitions(${example}
28+
PRIVATE
29+
NOMINMAX # Prevent min/max macros
30+
NOGDI # Prevent GDI macros (including ERROR)
31+
WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
32+
)
2833
endforeach()
2934
endif()
3035

tests/CMakeLists.txt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@ target_include_directories(unit_tests
4444

4545
# Windows-specific definitions
4646
if(MSVC)
47-
target_compile_definitions(unit_tests PRIVATE NOMINMAX)
47+
target_compile_definitions(unit_tests
48+
PRIVATE
49+
NOMINMAX # Prevent min/max macros
50+
NOGDI # Prevent GDI macros (including ERROR)
51+
WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
52+
)
4853
endif()
4954

5055
# Discover and register Google Test cases

0 commit comments

Comments
 (0)