remove windows support

Author: Calvinjmin

.clang-format

@@ -62,15 +62,12 @@ IncludeCategories:
   # Standard library
   - Regex:           '^<[a-z_]+>'
     Priority:        4
-  # Windows headers
-  - Regex:           '^<windows\.h>'
-    Priority:        5
   # ODBC headers
   - Regex:           '^<sql'
-    Priority:        6
+    Priority:        5
   # Third-party libraries
   - Regex:           '.*'
-    Priority:        7
+    Priority:        6
 
 # Other formatting
 BinPackArguments: true

.github/ISSUE_TEMPLATE/bug_report.md

@@ -11,8 +11,8 @@ assignees: ''
 <!-- A clear and concise description of what the bug is -->
 
 ## Environment
-- **OS**: <!-- e.g., macOS 14.0, Ubuntu 22.04, Windows 11 -->
-- **Compiler**: <!-- e.g., GCC 11.2, Clang 14, MSVC 2022 -->
+- **OS**: <!-- e.g., macOS 14.0, Ubuntu 22.04 -->
+- **Compiler**: <!-- e.g., GCC 11.2, Clang 14 -->
 - **SDK Version**: <!-- e.g., 0.3.0 -->
 - **CMake Version**: <!-- e.g., 3.25.0 -->
 - **ODBC Driver**: <!-- e.g., Simba Spark ODBC Driver 2.6.26 -->

.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
   cross-platform-tests:
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest]
 
     runs-on: ${{ matrix.os }}
 
@@ -42,14 +42,7 @@ jobs:
           fmt \
           nlohmann-json
 
-    - name: Install dependencies (Windows)
-      if: runner.os == 'Windows'
-      run: |
-        choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System'
-        vcpkg install curl spdlog fmt nlohmann-json
-
-    - name: Configure CMake (Linux/macOS)
-      if: runner.os != 'Windows'
+    - name: Configure CMake
       run: |
         mkdir -p build
         cd build
@@ -59,37 +52,16 @@ jobs:
           cmake -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Release ..
         fi
 
-    - name: Configure CMake (Windows)
-      if: runner.os == 'Windows'
-      run: |
-        mkdir build
-        cd build
-        cmake -DBUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake ..
-
-    - name: Build (Linux/macOS)
-      if: runner.os != 'Windows'
+    - name: Build
       run: |
         cd build
         cmake --build . --parallel $(nproc 2>/dev/null || sysctl -n hw.ncpu)
 
-    - name: Build (Windows)
-      if: runner.os == 'Windows'
-      run: |
-        cd build
-        cmake --build . --config Release --parallel
-
-    - name: Run unit tests (Linux/macOS)
-      if: runner.os != 'Windows'
+    - name: Run unit tests
       run: |
         cd build
         ctest --output-on-failure --verbose
 
-    - name: Run unit tests (Windows)
-      if: runner.os == 'Windows'
-      run: |
-        cd build
-        ctest -C Release --output-on-failure --verbose
-
   code-coverage:
     runs-on: ubuntu-latest
 

CMakeLists.txt

@@ -44,10 +44,7 @@ option(BUILD_TESTS "Build tests" OFF)
 option(BUILD_SHARED_LIBS "Build shared libraries" ON)
 
 # Platform-specific configuration
-if(WIN32)
-    # Windows uses odbc32
-    set(ODBC_LIBRARIES odbc32)
-elseif(APPLE)
+if(APPLE)
     # macOS: Prefer Homebrew paths on Apple Silicon
     if(NOT CMAKE_PREFIX_PATH AND CMAKE_SYSTEM_PROCESSOR MATCHES "arm64")
         list(PREPEND CMAKE_PREFIX_PATH "/opt/homebrew")
@@ -185,28 +182,15 @@ set_target_properties(databricks_sdk PROPERTIES
     SOVERSION ${PROJECT_VERSION_MAJOR}
 )
 
-# Set RPATH for finding ODBC libraries at runtime (Unix/Linux/macOS only)
-if(NOT WIN32)
-    # Use RPATH to find shared libraries relative to executable
-    set_target_properties(databricks_sdk PROPERTIES
-        BUILD_RPATH "${ODBC_LIBRARY_DIR};/usr/local/lib;/opt/homebrew/lib;/opt/local/lib"
-        INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;/usr/local/lib;/opt/homebrew/lib;/opt/local/lib"
-        INSTALL_RPATH_USE_LINK_PATH TRUE
-    )
-endif()
+# Set RPATH for finding ODBC libraries at runtime
+set_target_properties(databricks_sdk PROPERTIES
+    BUILD_RPATH "${ODBC_LIBRARY_DIR};/usr/local/lib;/opt/homebrew/lib;/opt/local/lib"
+    INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;/usr/local/lib;/opt/homebrew/lib;/opt/local/lib"
+    INSTALL_RPATH_USE_LINK_PATH TRUE
+)
 
-# Compiler warnings and definitions
-if(MSVC)
-    target_compile_options(databricks_sdk PRIVATE /W4)
-    target_compile_definitions(databricks_sdk
-        PRIVATE
-            NOMINMAX            # Prevent min/max macros
-            NOGDI               # Prevent GDI macros (including ERROR)
-            WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
-    )
-else()
-    target_compile_options(databricks_sdk PRIVATE -Wall -Wextra -Wpedantic)
-endif()
+# Compiler warnings
+target_compile_options(databricks_sdk PRIVATE -Wall -Wextra -Wpedantic)
 
 # Examples
 if(BUILD_EXAMPLES)

CONTRIBUTING.md

@@ -14,7 +14,7 @@ Thank you for your interest in contributing to the Databricks C++ SDK! This docu
 
 ### Prerequisites
 
-- C++17 compatible compiler (GCC 7+, Clang 5+, MSVC 2017+)
+- C++17 compatible compiler (GCC 7+, Clang 5+)
 - CMake 3.14 or higher
 - ODBC Driver Manager (unixODBC on Linux/macOS)
 - [Simba Spark ODBC Driver](https://www.databricks.com/spark/odbc-drivers-download)
@@ -248,7 +248,7 @@ TEST(ClientTest, QueryWithValidParameters) {
 4. **Style**: Does it follow project conventions?
 5. **Performance**: Any performance implications?
 6. **Security**: Any security concerns?
-7. **Compatibility**: Works on Linux/macOS/Windows?
+7. **Compatibility**: Works on Linux/macOS?
 
 ### Responding to Feedback
 

examples/CMakeLists.txt

@@ -20,19 +20,6 @@ target_link_libraries(unity_catalog_example PRIVATE databricks_sdk)
 add_executable(secrets_example secrets_example.cpp)
 target_link_libraries(secrets_example PRIVATE databricks_sdk)
 
-# Windows-specific definitions for all examples
-if(MSVC)
-    set(ALL_EXAMPLES simple_query jobs_example compute_example unity_catalog_example secrets_example)
-    foreach(example ${ALL_EXAMPLES})
-        target_compile_definitions(${example}
-            PRIVATE
-                NOMINMAX            # Prevent min/max macros
-                NOGDI               # Prevent GDI macros (including ERROR)
-                WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
-        )
-    endforeach()
-endif()
-
 # Set RPATH for all examples to find ODBC libraries
 set_target_properties(
     simple_query

include/databricks/internal/secure_string.h

@@ -6,12 +6,7 @@
 #include <cstring>
 #include <memory>
 #include <string>
-
-#ifdef _WIN32
-#    include <windows.h>
-#else
-#    include <sys/mman.h>
-#endif
+#include <sys/mman.h>
 
 namespace databricks {
 namespace internal {
@@ -86,26 +81,16 @@ template <typename T> class SecureAllocator {
      * @brief Lock memory pages to prevent swapping to disk
      */
     static void lock_memory(void* ptr, size_type size) noexcept {
-#ifdef _WIN32
-        // Use VirtualLock on Windows
-        // Ignore failures - locking is best-effort
-        VirtualLock(ptr, size);
-#else
         // Use mlock on POSIX systems
         // Ignore failures - locking is best-effort
         mlock(ptr, size);
-#endif
     }
 
     /**
      * @brief Unlock memory pages
      */
     static void unlock_memory(void* ptr, size_type size) noexcept {
-#ifdef _WIN32
-        VirtualUnlock(ptr, size);
-#else
         munlock(ptr, size);
-#endif
     }
 
     /**

src/core/client.cpp

@@ -19,9 +19,6 @@
 #include <stdexcept>
 #include <thread>
 
-#ifdef _WIN32
-#    include <windows.h>
-#endif
 #include <sql.h>
 #include <sqlext.h>
 

tests/CMakeLists.txt

@@ -8,7 +8,6 @@ FetchContent_Declare(
     GIT_TAG v1.14.0
 )
 
-# For Windows: Prevent overriding the parent project's compiler/linker settings
 set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
 
 FetchContent_MakeAvailable(googletest)
@@ -42,16 +41,6 @@ target_include_directories(unit_tests
         ${CMAKE_CURRENT_SOURCE_DIR}/mocks
 )
 
-# Windows-specific definitions
-if(MSVC)
-    target_compile_definitions(unit_tests
-        PRIVATE
-            NOMINMAX            # Prevent min/max macros
-            NOGDI               # Prevent GDI macros (including ERROR)
-            WIN32_LEAN_AND_MEAN # Reduce Windows header bloat
-    )
-endif()
-
 # Discover and register Google Test cases
 include(GoogleTest)
 gtest_discover_tests(unit_tests)