Skip to content

Clarify Identity Vault replacement coverage#908

Merged
riderx merged 3 commits into
mainfrom
codex/clarify-identity-vault-replacement
Jul 17, 2026
Merged

Clarify Identity Vault replacement coverage#908
riderx merged 3 commits into
mainfrom
codex/clarify-identity-vault-replacement

Conversation

@riderx

@riderx riderx commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Make Native Biometric explicitly the Identity Vault credential-vault replacement on the enterprise-plugin comparison page.
  • Show secure credential storage, biometric-gated reads, app-controlled lock policy, and iOS-only fallback for separate identity prompts.
  • Document that automatic timeout locks and privacy screens remain application policy, while custom-passcode and memory-only modes need a separate application storage and encryption design.

Screenshot

Identity Vault coverage

Visual diff

Generated with bun run visual-diff:compare (2 screenshots, fuzz 1%).

Status Suite Route Viewport Diff (px)
changed web /ionic-enterprise-plugins/ desktop 43322500000
changed web /ionic-enterprise-plugins/ mobile 28801100000

Summary:

  • identical: 0
  • minor: 0
  • changed: 2

Validation

  • bun run check
  • bun run build

Note

Low Risk
Documentation and static marketing page copy only; no application or plugin runtime behavior changes.

Overview
Docs and marketing now position Native Biometric as the direct replacement for Ionic Identity Vault credential-vault flows—not a biometric prompt plus Fast SQL / Data Storage SQLite.

The Native Biometric intro and Identity Vault migration guide are rewritten around Keychain/Keystore storage, getSecureCredentials, vault lifecycle APIs, and app-owned timeout, privacy-screen, and lock policy. The guides also state that custom passcode and memory-only vault modes are not supported and that optional SQLite plugins are only for data beyond credentials.

On /ionic-enterprise-plugins/, the comparison table drops the multi-plugin Identity Vault row, the hero CTA points at the Identity Vault migration doc, and a new Identity Vault coverage callout summarizes vault storage, biometric-gated reads, and lock policy.

Reviewed by Cursor Bugbot for commit 3552df1. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dc143ae9-0255-43c6-aad8-38abcb419185

📥 Commits

Reviewing files that changed from the base of the PR and between f88f941 and 3552df1.

📒 Files selected for processing (4)
  • .github/pr-assets/identity-vault-replacement.webp
  • apps/docs/src/content/docs/docs/plugins/native-biometric/index.mdx
  • apps/docs/src/content/docs/docs/upgrade/from-ionic-identity-vault.mdx
  • apps/web/src/pages/ionic-enterprise-plugins.astro

Comment @coderabbitai help to get the list of available commands.

@riderx
riderx marked this pull request as ready for review July 17, 2026 13:39
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_83ca4b1e-49d1-4fc2-9eb2-6c3ae86ddd8c)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; reviewers have been assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; no additional reviewers could be assigned on this repository.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@cursor
cursor Bot requested review from Pitiakova and WcaleNieWolny July 17, 2026 13:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed for these docs and enterprise marketing copy updates; reviewers Pitiakova and WcaleNieWolny have been assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread apps/docs/src/content/docs/docs/upgrade/from-ionic-identity-vault.mdx Outdated
Comment thread apps/web/src/pages/ionic-enterprise-plugins.astro Outdated
Comment thread apps/web/src/pages/ionic-enterprise-plugins.astro Outdated
Comment thread apps/docs/src/content/docs/docs/plugins/native-biometric/index.mdx Outdated
Comment thread apps/docs/src/content/docs/docs/upgrade/from-ionic-identity-vault.mdx Outdated
Comment thread apps/docs/src/content/docs/docs/upgrade/from-ionic-identity-vault.mdx Outdated
Comment thread apps/web/src/pages/ionic-enterprise-plugins.astro Outdated
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_a3c42746-1d4d-41a2-a9e8-3dbd1366d996)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; reviewers Pitiakova and WcaleNieWolny are already assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; reviewers Pitiakova and WcaleNieWolny are already assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/docs/src/content/docs/docs/upgrade/from-ionic-identity-vault.mdx Outdated
@cursor

cursor Bot commented Jul 17, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_c38e7f68-e817-4a4a-bd84-4e43f11125af)

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; reviewers Pitiakova and WcaleNieWolny are already assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot did not complete (check skipped due to usage limit), so the required automated review signal is unavailable. Human review is needed; reviewers Pitiakova and WcaleNieWolny are already assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@sonarqubecloud

Copy link
Copy Markdown

@riderx
riderx merged commit adec04f into main Jul 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant