address review feedback

Author: sixty-dollar-agent

apps/desktop/src-tauri/src/deeplink_actions.rs

@@ -2,11 +2,11 @@ use cap_recording::{
     RecordingMode, feeds::camera::DeviceOrModelID, sources::screen_capture::ScreenCaptureTarget,
 };
 use serde::{Deserialize, Serialize};
-use std::path::{Path, PathBuf};
+use std::path::PathBuf;
 use tauri::{AppHandle, Manager, Url};
 use tracing::trace;
 
-use crate::{App, ArcLock, recording::StartRecordingInputs, windows::ShowCapWindow};
+use crate::{App, ArcLock, recording::StartRecordingInputs, windows::{CapWindowId, ShowCapWindow}};
 
 #[derive(Debug, Serialize, Deserialize)]
 #[serde(rename_all = "snake_case")]
@@ -34,7 +34,26 @@ pub enum DeepLinkAction {
     },
 }
 
+pub fn setup_deeplink_handler(app_handle: &AppHandle) {
+    let app_handle = app_handle.clone();
+    app_handle
+        .clone()
+        .plugin(tauri_plugin_deep_link::init())
+        .ok();
+
+    let handle = app_handle.clone();
+    app_handle.listen("deep-link://new-url", move |event| {
+        if let Ok(urls) = serde_json::from_str::<Vec<Url>>(event.payload()) {
+            handle_urls(&handle, urls);
+        }
+    });
+}
+
 pub fn handle(app_handle: &AppHandle, urls: Vec<Url>) {
+    handle_urls(app_handle, urls);
+}
+
+fn handle_urls(app_handle: &AppHandle, urls: Vec<Url>) {
     trace!("Handling deep actions for: {:?}", &urls);
 
     let actions: Vec<_> = urls
@@ -145,14 +164,23 @@ impl DeepLinkAction {
                     .map(|_| ())
             }
             DeepLinkAction::StopRecording => {
-                crate::recording::stop_recording(app.clone(), app.state()).await
+                crate::recording::stop_recording(app.clone(), app.state())
+                    .await
+                    .map_err(|e| e.to_string())
             }
             DeepLinkAction::OpenEditor { project_path } => {
-                crate::open_project_from_path(Path::new(&project_path), app.clone())
+                use crate::windows::ShowCapWindow;
+                CapWindowId::Editor {
+                    project_path: project_path.clone(),
+                }
+                .show(app)
+                .map_err(|e| e.to_string())
             }
             DeepLinkAction::OpenSettings { page } => {
-                crate::show_window(app.clone(), ShowCapWindow::Settings { page }).await
+                CapWindowId::Settings { page }
+                    .show(app)
+                    .map_err(|e| e.to_string())
             }
         }
     }
-}
+}

apps/raycast-extension/src/start-recording.ts

@@ -0,0 +1,7 @@
+import { open, showHUD } from "@raycast/api";
+
+export default async function startRecording() {
+  const url = "cap://action?value=" + encodeURIComponent(JSON.stringify({ start_recording: {} }));
+  await open(url);
+  await showHUD("Starting Cap recording…");
+}