coderabbit

Author: richiemcilroy

.claude/settings.local.json

@@ -48,7 +48,9 @@
 			"Bash(powershell -Command \"[System.Environment]::OSVersion.Version.ToString()\")",
 			"Bash(cargo build:*)",
 			"Bash(gh api:*)",
-			"Bash(curl:*)"
+			"Bash(curl:*)",
+			"Bash(node -e:*)",
+			"Bash(findstr:*)"
 		],
 		"deny": [],
 		"ask": []

Cargo.lock

@@ -123,7 +123,7 @@ pub struct GeneralSettingsStore {
     pub instant_mode_max_resolution: u32,
     #[serde(default)]
     pub default_project_name_template: Option<String>,
-    #[serde(default = "default_true")]
+    #[serde(default)]
     pub crash_recovery_recording: bool,
 }
 

apps/desktop/src-tauri/src/general_settings.rs

@@ -7,6 +7,7 @@ edition = "2024"
 cap-media-info = { path = "../media-info" }
 futures.workspace = true
 thiserror.workspace = true
+tracing.workspace = true
 workspace-hack = { version = "0.1", path = "../workspace-hack" }
 
 [target.'cfg(windows)'.dependencies]

crates/enc-mediafoundation/Cargo.toml

@@ -427,10 +427,7 @@ impl HevcEncoder {
                         }
                     }
                     _ => {
-                        eprintln!(
-                            "[cap-enc-mediafoundation] Ignoring unknown media event type: {}",
-                            event_type.0
-                        );
+                        tracing::warn!("Ignoring unknown media event type: {}", event_type.0);
                     }
                 }
             }

crates/enc-mediafoundation/src/video/hevc.rs

@@ -285,7 +285,10 @@ impl Muxer for WindowsMuxer {
                                 Ok(Some((frame.texture().clone(), frame_time)))
                             },
                             |output_sample| {
-                                let mut output = output.lock().unwrap();
+                                let Ok(mut output) = output.lock() else {
+                                    tracing::error!("Failed to lock output mutex - poisoned");
+                                    return Ok(());
+                                };
 
                                 if let Err(e) = muxer.write_sample(&output_sample, &mut output) {
                                     tracing::error!("WriteSample failed: {e}");

crates/recording/src/output_pipeline/win.rs

@@ -516,7 +516,12 @@ impl WindowsSegmentedCameraMuxer {
                                 Ok(Some((texture, duration_to_timespan(relative))))
                             },
                             |output_sample| {
-                                let mut output = output_clone.lock().unwrap();
+                                let mut output = output_clone.lock().map_err(|e| {
+                                    windows::core::Error::new(
+                                        windows::core::HRESULT(-1),
+                                        format!("Mutex poisoned: {e}"),
+                                    )
+                                })?;
                                 muxer
                                     .write_sample(&output_sample, &mut output)
                                     .map_err(|e| {