clippy

Author: richiemcilroy

crates/enc-mediafoundation/src/media.rs

@@ -22,7 +22,7 @@ unsafe fn MFSetAttribute2UINT32asUINT64(
     unsafe { attributes.SetUINT64(key, pack_2_u32_as_u64(high, low)) }
 }
 
-#[allow(non_snake_case)]
+#[allow(non_snake_case, clippy::missing_safety_doc)]
 pub unsafe fn MFSetAttributeSize(
     attributes: &IMFAttributes,
     key: &GUID,
@@ -32,7 +32,7 @@ pub unsafe fn MFSetAttributeSize(
     unsafe { MFSetAttribute2UINT32asUINT64(attributes, key, width, height) }
 }
 
-#[allow(non_snake_case)]
+#[allow(non_snake_case, clippy::missing_safety_doc)]
 pub unsafe fn MFSetAttributeRatio(
     attributes: &IMFAttributes,
     key: &GUID,

crates/enc-mediafoundation/src/video/h264.rs

@@ -101,6 +101,7 @@ pub enum HandleNeedsInputError {
 unsafe impl Send for H264Encoder {}
 
 impl H264Encoder {
+    #[allow(clippy::too_many_arguments)]
     fn new_with_scaled_output_with_flags(
         d3d_device: &ID3D11Device,
         format: DXGI_FORMAT,
@@ -210,7 +211,10 @@ impl H264Encoder {
         unsafe {
             let temp = media_device_manager.clone();
             transform
-                .ProcessMessage(MFT_MESSAGE_SET_D3D_MANAGER, std::mem::transmute(temp))
+                .ProcessMessage(
+                    MFT_MESSAGE_SET_D3D_MANAGER,
+                    std::mem::transmute::<_, usize>(temp),
+                )
                 .map_err(NewVideoEncoderError::EncoderTransform)?;
         };
 

crates/mediafoundation-ffmpeg/src/audio.rs

@@ -22,7 +22,7 @@ impl AudioExt for ffmpeg::frame::Audio {
         unsafe { buffer.Lock(&mut buffer_ptr, None, None)? };
 
         unsafe {
-            std::ptr::copy_nonoverlapping(self.data(0).as_ptr(), buffer_ptr, length as usize);
+            std::ptr::copy_nonoverlapping(self.data(0).as_ptr(), buffer_ptr, length);
         }
 
         unsafe { buffer.SetCurrentLength(length as u32)? }

crates/recording/src/screenshot.rs

@@ -640,7 +640,7 @@ pub async fn capture_screenshot(target: ScreenCaptureTarget) -> anyhow::Result<R
     }
 
     #[cfg(target_os = "windows")]
-    let mut cropped_in_capture = false;
+    let cropped_in_capture;
 
     let (tx, rx) = oneshot::channel::<anyhow::Result<RgbImage>>();
     let tx = Arc::new(Mutex::new(Some(tx)));

crates/recording/src/sources/screen_capture/windows.rs

@@ -8,7 +8,7 @@ use cap_media_info::{AudioInfo, VideoInfo};
 use cap_timestamp::{PerformanceCounterTimestamp, Timestamp};
 use cpal::traits::{DeviceTrait, HostTrait};
 use futures::{
-    FutureExt, SinkExt, StreamExt,
+    FutureExt, StreamExt,
     channel::{mpsc, oneshot},
 };
 use scap_ffmpeg::*;
@@ -201,7 +201,7 @@ impl output_pipeline::VideoSource for VideoSource {
 	                }
                 },
                 {
-                    let error_tx = error_tx.clone();
+                    let mut error_tx = error_tx.clone();
                     move || {
                         drop(error_tx.try_send(anyhow!("closed")));