Commit d045c4f
fix(windows): revert editor to RGBA output and fix DX12 adapter selection
Two issues discovered during testing on Windows with NVIDIA RTX 2000:
1. The NV12 render pipeline (RgbaToNv12Converter compute shader + buffer
readback) hangs on the Vulkan backend, causing BufferAsyncError and
preventing any frame from being delivered to the editor. Reverted the
editor renderer back to the proven render_immediate() RGBA path which
works reliably on all backends. The NV12 path remains available for
export where it has been battle-tested.
2. The DX12 | Vulkan backend specification allowed wgpu to pick Vulkan
over DX12 (seen in logs: adapter_backend=Vulkan despite DX12 being
listed). This prevents D3D11 shared handle zero-copy since that
requires a D3D12 device. Fixed by creating a DX12-only instance first
to probe for DX12 availability, then falling back to all backends only
if DX12 isn't available. This ensures DX12 is used when present.
Co-authored-by: Richie McIlroy <richiemcilroy@users.noreply.github.com>1 parent e53808a commit d045c4f
File tree
3 files changed
+55
-47
lines changed- apps/desktop/src-tauri/src
- crates
- editor/src
- rendering/src
3 files changed
+55
-47
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 52 | | |
58 | 53 | | |
59 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
60 | 78 | | |
61 | 79 | | |
62 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
173 | 161 | | |
174 | 162 | | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
| 163 | + | |
192 | 164 | | |
193 | 165 | | |
194 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
979 | 979 | | |
980 | 980 | | |
981 | 981 | | |
982 | | - | |
983 | | - | |
984 | | - | |
985 | | - | |
986 | | - | |
987 | 982 | | |
988 | 983 | | |
989 | 984 | | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
990 | 1008 | | |
991 | 1009 | | |
992 | 1010 | | |
| |||
0 commit comments