fix: Handle C++ exceptions during capture item creation in Windows thumbnails#1377
Draft
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Draft
fix: Handle C++ exceptions during capture item creation in Windows thumbnails#1377seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CAP-DESKTOP-T7. The issue was that: Race condition between window enumeration and
CreateForWindowcauses Windows Graphics Capture API to throw an unhandled C++ exception on invalid HWND.try_as_capture_itemcalls incatch_unwindto handle C++ exceptions that can occur if the display or window is disconnected or destroyed between enumeration and capture.This fix was generated by Seer in Sentry, triggered by Richie. 👁️ Run ID: 2575840
Not quite right? Click here to continue debugging with Seer.