Skip to content

fix(macos): remove redundant activation policy toggle causing duplicate dock icons #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ManthanNimodiya wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −3
Open

fix(macos): remove redundant activation policy toggle causing duplicate dock icons #1849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0695bd
fix(macos): remove redundant activation policy toggle in prepare_maco…
ManthanNimodiya May 20, 2026
c00cefa
fix(macos): prevent duplicate dock icons during recording start
ManthanNimodiya May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions apps/desktop/src-tauri/src/permissions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,12 @@ fn macos_sync_activation_policy(app: &tauri::AppHandle, should_show_dock: bool)
pub(crate) fn prepare_macos_panel_window(
app: &tauri::AppHandle,
) -> MacosPanelWindowActivationGuard {
MACOS_PENDING_PANEL_WINDOWS.fetch_add(1, Ordering::AcqRel);
let prev = MACOS_PENDING_PANEL_WINDOWS.fetch_add(1, Ordering::AcqRel);

if let Err(err) = app.set_activation_policy(tauri::ActivationPolicy::Accessory) {
tracing::warn!("Failed to prepare macOS panel activation policy: {err}");
if prev == 0 {
if let Err(err) = app.set_activation_policy(tauri::ActivationPolicy::Accessory) {
tracing::warn!("Failed to prepare macOS panel activation policy: {err}");
}
}

MacosPanelWindowActivationGuard { app: app.clone() }
Expand All @@ -177,6 +179,16 @@ pub(crate) fn sync_macos_dock_visibility(app: &tauri::AppHandle) {
return;
}

let has_visible_panel_window = app.webview_windows().iter().any(|(label, window)| {
CapWindowId::from_str(label)
.map(|id| !id.activates_dock() && window.is_visible().unwrap_or(false))
.unwrap_or(false)
});

if has_visible_panel_window {
return;
}

let should_hide_dock = GeneralSettingsStore::get(app)
.ok()
.flatten()
Expand Down
Loading