Improve error handling for uploads and defects

Author: richiemcilroy

apps/api/src/routes/files.ts

@@ -100,12 +100,12 @@ const uploadFile = Effect.gen(function* () {
     return yield* Effect.fail(new ValidationError({ message: 'path query parameter is required' }))
   }
 
-  // Read body as array buffer — catch @effect/platform RequestError
+  // Read body as array buffer — catch all errors from body reading
   const arrayBuffer = yield* request.arrayBuffer.pipe(
-    Effect.catchTag('RequestError', (err) =>
+    Effect.catchAllCause((cause) =>
       Effect.fail(
         new InternalError({
-          message: `Failed to read upload body: ${err.message}`,
+          message: `Failed to read upload body: ${Cause.pretty(cause)}`,
         }),
       ),
     ),

apps/api/src/server.ts

@@ -1,7 +1,7 @@
 import { HttpMiddleware, HttpRouter, HttpServer, HttpServerRequest, HttpServerResponse } from '@effect/platform'
 import { Effect } from 'effect'
 import { auth } from './auth.js'
-import { formatApiError } from './errors.js'
+import { formatApiError, InternalError } from './errors.js'
 import { withRequestId } from './middleware.js'
 import { withConnectionDrain } from './middleware/connection-drain.js'
 import { withRateLimit } from './middleware/rate-limit.js'
@@ -51,7 +51,7 @@ const withDefectHandler = HttpMiddleware.make((app) =>
       Effect.gen(function* () {
         const message = defect instanceof Error ? defect.message : String(defect)
         yield* Effect.logError(`Unhandled defect: ${message}`)
-        return formatApiError(new Error('internal defect'))
+        return formatApiError(new InternalError({ message }))
       }),
     ),
   ),