fix: resolve clippy warning and separate performance tests from CI

Author: richiemcilroy

.github/workflows/test.yml

@@ -114,8 +114,8 @@ jobs:
       - name: Build native module
         run: npm run build
 
-      - name: Run tests
-        run: npm test
+      - name: Run tests (excluding performance tests)
+        run: npm test -- --exclude '**/{benchmark,performance-regression}.test.ts'
 
       - name: Upload test artifacts on failure
         if: failure()
@@ -161,3 +161,46 @@ jobs:
 
       - name: Clippy
         run: cargo clippy -- -D warnings
+
+  benchmark:
+    name: Performance Benchmarks (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    continue-on-error: true
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: 'npm'
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Cache cargo
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            target/
+          key: ${{ runner.os }}-cargo-bench-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-cargo-bench-
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Build native module
+        run: npm run build
+
+      - name: Run performance tests (informational)
+        run: npm test -- tests/benchmark.test.ts tests/performance-regression.test.ts --testTimeout=120000

src/walker.rs

@@ -314,34 +314,31 @@ impl Walker {
         // Apply pruning filter if set
         if let Some(ref prune_filter) = self.dir_prune_filter {
             let root = self.root.clone();
-            entries = entries
-                .into_iter()
-                .filter(|entry| {
-                    if let Ok(rel_path) = entry.path().strip_prefix(&root) {
-                        let rel_lossy = rel_path.to_string_lossy();
-                        let rel_str = normalize_path_str(&rel_lossy);
-                        // Root directory always passes
-                        if rel_str.is_empty() {
-                            return true;
-                        }
-                        // For directories, check if they should be included
-                        if entry.is_dir() && !prune_filter(&rel_str) {
-                            return false;
-                        }
-                        // For files, check if their parent directory passes the filter
-                        if !entry.is_dir() {
-                            if let Some(parent) = rel_path.parent() {
-                                let parent_lossy = parent.to_string_lossy();
-                                let parent_str = normalize_path_str(&parent_lossy);
-                                if !parent_str.is_empty() && !prune_filter(&parent_str) {
-                                    return false;
-                                }
+            entries.retain(|entry| {
+                if let Ok(rel_path) = entry.path().strip_prefix(&root) {
+                    let rel_lossy = rel_path.to_string_lossy();
+                    let rel_str = normalize_path_str(&rel_lossy);
+                    // Root directory always passes
+                    if rel_str.is_empty() {
+                        return true;
+                    }
+                    // For directories, check if they should be included
+                    if entry.is_dir() && !prune_filter(&rel_str) {
+                        return false;
+                    }
+                    // For files, check if their parent directory passes the filter
+                    if !entry.is_dir() {
+                        if let Some(parent) = rel_path.parent() {
+                            let parent_lossy = parent.to_string_lossy();
+                            let parent_str = normalize_path_str(&parent_lossy);
+                            if !parent_str.is_empty() && !prune_filter(&parent_str) {
+                                return false;
                             }
                         }
                     }
-                    true
-                })
-                .collect();
+                }
+                true
+            });
         }
 
         Box::new(entries.into_iter())