fix: normalize paths in additional windows compat tests

Author: richiemcilroy

tests/compat/custom-ignore.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { describe, it, expect, beforeAll, afterAll } from 'vitest'
-import { basename } from 'path'
+import { basename, isAbsolute } from 'path'
 import { glob as globOriginal, globSync as globSyncOriginal, type IgnoreLike } from 'glob'
 import { glob, globSync, IgnorePattern, Path } from '../../js/index.js'
 import { createTestFixture, cleanupFixture, FixtureConfig } from '../harness.js'
@@ -344,11 +344,11 @@ describe('custom ignore objects', () => {
 
       const results = globSync('*', { cwd: fixture, ignore, absolute: true })
 
-      // Should not include 'a' file
-      expect(results.some(r => r.endsWith('/a'))).toBe(false)
+      // Should not include 'a' file (check with both forward and back slashes for cross-platform)
+      expect(results.some(r => r.endsWith('/a') || r.endsWith('\\a'))).toBe(false)
 
-      // Paths should be absolute
-      expect(results.every(r => r.startsWith('/'))).toBe(true)
+      // Paths should be absolute (use Node's isAbsolute for cross-platform check)
+      expect(results.every(r => isAbsolute(r))).toBe(true)
     })
 
     it('should work with mark option', () => {

tests/compat/dot-relative.test.ts

@@ -9,6 +9,12 @@ import { sep } from 'path'
 import { glob as globOriginal, globSync as globSyncOriginal, Glob as GlobOriginal } from 'glob'
 import { createTestFixture, cleanupFixture, loadGloblin, DEFAULT_FIXTURE } from '../harness.js'
 
+// Helper to check if path starts with ./ or .\ (cross-platform dotRelative prefix)
+const startsWithDotSlash = (path: string): boolean =>
+  path.startsWith('./') || path.startsWith('.\\')
+// Normalize path to use forward slashes
+const normalize = (path: string): string => path.replace(/\\/g, '/')
+
 describe('dot-relative - prepend ./ to relative paths', () => {
   let fixturePath: string
   let globlin: Awaited<ReturnType<typeof loadGloblin>>
@@ -66,7 +72,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
 
       expect(results.length).toBeGreaterThan(0)
       for (const m of results) {
-        expect(m.startsWith('./')).toBe(true)
+        expect(startsWithDotSlash(m)).toBe(true)
       }
     })
 
@@ -79,7 +85,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
 
       expect(results.length).toBeGreaterThan(0)
       for (const m of results) {
-        expect(m.startsWith('./')).toBe(true)
+        expect(startsWithDotSlash(m)).toBe(true)
       }
     })
 
@@ -92,7 +98,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
 
       expect(results.length).toBeGreaterThan(0)
       for (const m of results) {
-        expect(m.startsWith('./')).toBe(false)
+        expect(startsWithDotSlash(m)).toBe(false)
       }
     })
 
@@ -105,7 +111,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
 
       expect(results.length).toBeGreaterThan(0)
       for (const m of results) {
-        expect(m.startsWith('./')).toBe(false)
+        expect(startsWithDotSlash(m)).toBe(false)
       }
     })
   })
@@ -145,7 +151,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
       }
       const results = await globlin.glob('a/b/c/d', { cwd: fixturePath, dotRelative: true })
       expect(results.length).toBe(1)
-      expect(results[0]).toBe('./a/b/c/d')
+      expect(normalize(results[0])).toBe('./a/b/c/d')
     })
 
     it('works with ** pattern', async () => {
@@ -155,7 +161,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
       }
       const results = await globlin.glob('**/*.txt', { cwd: fixturePath, dotRelative: true })
       for (const m of results) {
-        expect(m.startsWith('./')).toBe(true)
+        expect(startsWithDotSlash(m)).toBe(true)
       }
     })
 
@@ -172,7 +178,7 @@ describe('dot-relative - prepend ./ to relative paths', () => {
       })
       for (const m of results) {
         // Absolute paths should not start with ./
-        expect(m.startsWith('./')).toBe(false)
+        expect(startsWithDotSlash(m)).toBe(false)
       }
     })
   })

tests/compat/dot.test.ts

@@ -9,6 +9,10 @@ import { createTestFixture, cleanupFixture, loadGloblin, type GloblinModule } fr
 let fixtureDir: string
 let globlin: GloblinModule
 
+// Normalize paths for cross-platform comparison (replace backslashes with forward slashes)
+const normalize = (paths: string[]): string[] => paths.map(p => p.replace(/\\/g, '/'))
+const normalizeStr = (path: string): string => path.replace(/\\/g, '/')
+
 // Fixture with dotfiles
 const DOT_FILE_FIXTURE = {
   files: [
@@ -75,13 +79,17 @@ describe('Dot file handling', () => {
       const globResults = await glob('nested/**/*', { cwd: fixtureDir })
       const globlinResults = await globlin.glob('nested/**/*', { cwd: fixtureDir })
 
+      // Normalize paths for cross-platform comparison
+      const normalizedGlob = normalize(globResults)
+      const normalizedGloblin = normalize(globlinResults)
+
       // Should include visible files
-      expect(globResults).toContain('nested/visible')
-      expect(globResults).toContain('nested/visible/file.txt')
+      expect(normalizedGlob).toContain('nested/visible')
+      expect(normalizedGlob).toContain('nested/visible/file.txt')
 
       // Globlin should match
-      expect(globlinResults).toContain('nested/visible')
-      expect(globlinResults).toContain('nested/visible/file.txt')
+      expect(normalizedGloblin).toContain('nested/visible')
+      expect(normalizedGloblin).toContain('nested/visible/file.txt')
     })
   })
 
@@ -104,29 +112,37 @@ describe('Dot file handling', () => {
       const globResults = await glob('**/*', { cwd: fixtureDir, dot: true })
       const globlinResults = await globlin.glob('**/*', { cwd: fixtureDir, dot: true })
 
-      // Should include dotfiles
-      expect(globResults).toContain('.hidden')
-      expect(globResults).toContain('.git/config')
-      expect(globResults).toContain('src/.env')
-      expect(globResults).toContain('nested/.config')
+      // Normalize paths for cross-platform comparison
+      const normalizedGlob = normalize(globResults)
+      const normalizedGloblin = normalize(globlinResults)
 
-      expect(globlinResults).toContain('.hidden')
-      expect(globlinResults).toContain('.git/config')
-      expect(globlinResults).toContain('src/.env')
-      expect(globlinResults).toContain('nested/.config')
+      // Should include dotfiles
+      expect(normalizedGlob).toContain('.hidden')
+      expect(normalizedGlob).toContain('.git/config')
+      expect(normalizedGlob).toContain('src/.env')
+      expect(normalizedGlob).toContain('nested/.config')
+
+      expect(normalizedGloblin).toContain('.hidden')
+      expect(normalizedGloblin).toContain('.git/config')
+      expect(normalizedGloblin).toContain('src/.env')
+      expect(normalizedGloblin).toContain('nested/.config')
     })
 
     it('should include files inside dotdirs with **/*', async () => {
       const globResults = await glob('**/*', { cwd: fixtureDir, dot: true })
       const globlinResults = await globlin.glob('**/*', { cwd: fixtureDir, dot: true })
 
-      expect(globResults).toContain('.git/config')
-      expect(globResults).toContain('.git/HEAD')
-      expect(globResults).toContain('nested/.config/settings.json')
+      // Normalize paths for cross-platform comparison
+      const normalizedGlob = normalize(globResults)
+      const normalizedGloblin = normalize(globlinResults)
+
+      expect(normalizedGlob).toContain('.git/config')
+      expect(normalizedGlob).toContain('.git/HEAD')
+      expect(normalizedGlob).toContain('nested/.config/settings.json')
 
-      expect(globlinResults).toContain('.git/config')
-      expect(globlinResults).toContain('.git/HEAD')
-      expect(globlinResults).toContain('nested/.config/settings.json')
+      expect(normalizedGloblin).toContain('.git/config')
+      expect(normalizedGloblin).toContain('.git/HEAD')
+      expect(normalizedGloblin).toContain('nested/.config/settings.json')
     })
   })
 
@@ -143,24 +159,27 @@ describe('Dot file handling', () => {
       const globResults = await glob('.git/*', { cwd: fixtureDir })
       const globlinResults = await globlin.glob('.git/*', { cwd: fixtureDir })
 
-      expect(globResults.sort()).toEqual(['.git/HEAD', '.git/config'].sort())
-      expect(globlinResults.sort()).toEqual(['.git/HEAD', '.git/config'].sort())
+      // Normalize paths for cross-platform comparison
+      expect(normalize(globResults).sort()).toEqual(['.git/HEAD', '.git/config'].sort())
+      expect(normalize(globlinResults).sort()).toEqual(['.git/HEAD', '.git/config'].sort())
     })
 
     it('should match **/.env without dot option', async () => {
       const globResults = await glob('**/.env', { cwd: fixtureDir })
       const globlinResults = await globlin.glob('**/.env', { cwd: fixtureDir })
 
-      expect(globResults).toContain('src/.env')
-      expect(globlinResults).toContain('src/.env')
+      // Normalize paths for cross-platform comparison
+      expect(normalize(globResults)).toContain('src/.env')
+      expect(normalize(globlinResults)).toContain('src/.env')
     })
 
     it('should match nested dotdir pattern without dot option', async () => {
       const globResults = await glob('nested/.config/*', { cwd: fixtureDir })
       const globlinResults = await globlin.glob('nested/.config/*', { cwd: fixtureDir })
 
-      expect(globResults).toContain('nested/.config/settings.json')
-      expect(globlinResults).toContain('nested/.config/settings.json')
+      // Normalize paths for cross-platform comparison
+      expect(normalize(globResults)).toContain('nested/.config/settings.json')
+      expect(normalize(globlinResults)).toContain('nested/.config/settings.json')
     })
   })