Added compression and switched to recursive binary serialisation for asset packing#69
Merged
Added compression and switched to recursive binary serialisation for asset packing#69
Conversation
Raelr
approved these changes
Aug 5, 2025
Contributor
Raelr
left a comment
There was a problem hiding this comment.
This is awful. I hate everything that I see here and you should be especially ashamed of the use of smart pointers.
LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the packing system to perform compression on packed data via
zlibwhere the resource system is equipped to handle decompression of loaded pack file. This feature functions in concert with a newly added binary serialisation method for asset data using recursive template functions. The results show therenderapppack file size reduced in on-disk size from 6.4MB down to 2.8MB.The recursive templates for binary serialisation work as so at the high level, allowing any type to recursively request the serialisation of data (likely members) for any type that provides a template function to do so as below:
The functionality then allows for more common and fundamental types to receive serialisation based on native serialisation rules as defined in
utils/BinarySerialisation.h, such as STL containers, primitive C++ types, and core Siege types.In addition to these new features, the following changes have also been made:
pack-assetstargets in all Makefiles have been updated to perform their deletions before runningThe PR has been...
The code has been...
master(according to GitHub)packagetargets