Merge pull request #52 from CarboxyDev/development

Fix web dockerfile missing env var

Author: CarboxyDev

.github/workflows/cd.yml

@@ -104,6 +104,6 @@ jobs:
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           build-args: |
-            NEXT_PUBLIC_API_URL=${{ vars.NEXT_PUBLIC_API_URL }}
+            NEXT_PUBLIC_API_URL=${{ vars.NEXT_PUBLIC_API_URL != '' && vars.NEXT_PUBLIC_API_URL || 'http://localhost:8080/api' }}
           cache-from: type=gha
           cache-to: type=gha,mode=max

apps/web/Dockerfile

@@ -50,9 +50,10 @@ COPY --from=deps /app/packages/tailwind-config/node_modules ./packages/tailwind-
 # Copy source code
 COPY . .
 
-# Build arguments for environment variables needed at build time
-ARG NEXT_PUBLIC_API_URL
-ENV NEXT_PUBLIC_API_URL=$NEXT_PUBLIC_API_URL
+# Build arguments for environment variables needed at build time.
+# Default keeps CI/CD builds working even when build-arg is omitted.
+ARG NEXT_PUBLIC_API_URL=http://localhost:8080/api
+ENV NEXT_PUBLIC_API_URL=${NEXT_PUBLIC_API_URL}
 
 # Build the web app (standalone output configured in next.config.ts)
 RUN pnpm --filter @repo/web build