AI perf follow-ups: fog check caching, tap/untap scan zones, chump block re-evaluation (#11160)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: Blackvipe99

forge-ai/src/main/java/forge/ai/AiBlockController.java

@@ -649,7 +649,14 @@ private void makeChumpBlocks(final Combat combat) {
     }
 
     private void makeChumpBlocks(final Combat combat, List<Card> attackers) {
-        if (!ComputerUtilCombat.lifeInDanger(ai, combat)) {
+        makeChumpBlocks(combat, attackers, true);
+    }
+
+    // recheckDanger: lifeInDanger runs a full combat damage prediction, so only
+    // re-evaluate it when a blocker was assigned since the last check - skipping
+    // an attacker leaves the combat unchanged and the previous result still holds
+    private void makeChumpBlocks(final Combat combat, List<Card> attackers, boolean recheckDanger) {
+        if (recheckDanger && !ComputerUtilCombat.lifeInDanger(ai, combat)) {
             lifeInDanger = false;
             return;
         }
@@ -663,10 +670,11 @@ private void makeChumpBlocks(final Combat combat, List<Card> attackers) {
             || StaticAbilityAssignCombatDamageAsUnblocked.assignCombatDamageAsUnblocked(attacker)
             || ComputerUtilCombat.attackerHasThreateningAfflict(attacker, ai)) {
             attackers.remove(0);
-            makeChumpBlocks(combat, attackers);
+            makeChumpBlocks(combat, attackers, false);
             return;
         }
 
+        boolean blocked = false;
         List<Card> chumpBlockers = getPossibleBlockers(combat, attacker, blockersLeft, true);
         if (!chumpBlockers.isEmpty()) {
             final Card blocker = ComputerUtilCard.getWorstCreatureAI(chumpBlockers);
@@ -688,7 +696,7 @@ private void makeChumpBlocks(final Combat combat, List<Card> attackers) {
                             attackersLeft.remove(other);
                             blockedButUnkilled.add(other);
                             attackers.remove(other);
-                            makeChumpBlocks(combat, attackers);
+                            makeChumpBlocks(combat, attackers, true);
                             return;
                         }
                     }
@@ -698,9 +706,10 @@ private void makeChumpBlocks(final Combat combat, List<Card> attackers) {
             combat.addBlocker(attacker, blocker);
             attackersLeft.remove(attacker);
             blockedButUnkilled.add(attacker);
+            blocked = true;
         }
         attackers.remove(0);
-        makeChumpBlocks(combat, attackers);
+        makeChumpBlocks(combat, attackers, blocked);
     }
 
     // Block creatures with "can't be blocked except by two or more creatures"

forge-ai/src/main/java/forge/ai/ComputerUtilCombat.java

@@ -2228,11 +2228,20 @@ public final static int predictDamageTo(final GameEntity target, final int damag
         int restDamage = damage;
 
         restDamage = target.staticReplaceDamage(restDamage, source, isCombat);
-        restDamage = target.staticDamagePrevention(restDamage, possiblePrevention, source, isCombat);
+        restDamage = target.staticDamagePrevention(restDamage, possiblePrevention, source, isCombat,
+                isCombat ? isCombatDamagePreventedThisTurnCached(target.getGame()) : null);
 
         return restDamage;
     }
 
+    // cached per AI decision (AiCache is cleared in chooseSpellAbilityToPlay);
+    // predictions ask this once per attacker otherwise
+    private static Boolean isCombatDamagePreventedThisTurnCached(final Game game) {
+        return AiCache.getCached("isPreventCombatDamageThisTurn",
+                () -> game.getReplacementHandler().isPreventCombatDamageThisTurn(),
+                List.of(AiCache::identity), game);
+    }
+
     public final static boolean dealsFirstStrikeDamage(final Card combatant, final boolean withoutAbilities, final Combat combat) {
         if (combatant.hasFirstStrike() || combatant.hasDoubleStrike()) {
             return true;

forge-game/src/main/java/forge/game/GameEntity.java

@@ -79,15 +79,27 @@ public void setName(final String s) {
     // This should be also usable by the AI to forecast an effect (so it must
     // not change the game state)
     public int staticDamagePrevention(int damage, final int possiblePrevention, final Card source, final boolean isCombat) {
+        return staticDamagePrevention(damage, possiblePrevention, source, isCombat, null);
+    }
+
+    // combatDamagePreventedThisTurn: optional precomputed result of
+    // ReplacementHandler.isPreventCombatDamageThisTurn, so the AI can cache it
+    // instead of re-running the check for every attacker of a predicted combat
+    public int staticDamagePrevention(int damage, final int possiblePrevention, final Card source, final boolean isCombat, final Boolean combatDamagePreventedThisTurn) {
         if (damage <= 0) {
             return 0;
         }
         if (!source.canDamagePrevented(isCombat)) {
             return damage;
         }
 
-        if (isCombat && getGame().getReplacementHandler().isPreventCombatDamageThisTurn()) {
-            return 0;
+        if (isCombat) {
+            final boolean prevented = combatDamagePreventedThisTurn != null
+                    ? combatDamagePreventedThisTurn.booleanValue()
+                    : getGame().getReplacementHandler().isPreventCombatDamageThisTurn();
+            if (prevented) {
+                return 0;
+            }
         }
 
         for (final Card ca : getGame().getCardsIn(ZoneType.STATIC_ABILITIES_SOURCE_ZONES)) {

forge-game/src/main/java/forge/game/replacement/ReplacementHandler.java

@@ -42,6 +42,7 @@
 import forge.game.player.Player;
 import forge.game.player.PlayerCollection;
 import forge.game.spellability.AbilitySub;
+import forge.game.spellability.Spell;
 import forge.game.spellability.SpellAbility;
 import forge.game.zone.Zone;
 import forge.game.zone.ZoneType;
@@ -102,6 +103,18 @@ public List<ReplacementEffect> getReplacementList(final ReplacementType event, f
             Card c = preList.get(crd);
             Zone cardZone = game.getZoneOf(c);
 
+            // all tap/untap replacements are active from the battlefield or the command zone
+            // (e.g. Ood Sphere); skip other zones - this is a major hot path, as canTap/canUntap
+            // run a cantHappenCheck per mana source per AI cost check
+            // (performance mode only, in case a custom card wants one active from elsewhere)
+            if (Spell.isPerformanceMode()
+                    && (event == ReplacementType.Tap || event == ReplacementType.Untap)
+                    && cardZone != null
+                    && cardZone.getZoneType() != ZoneType.Battlefield
+                    && cardZone.getZoneType() != ZoneType.Command) {
+                return true;
+            }
+
             // only when not prelist
             boolean noLKIstate = c != crd || event != ReplacementType.Moved || c.isImmutable() || runParams.get(AbilityKey.LastStateBattlefield) == null;
             if (!noLKIstate) {

forge-game/src/main/java/forge/game/spellability/Spell.java

@@ -54,6 +54,10 @@ public static void setPerformanceMode(boolean performanceMode){
         Spell.performanceMode=performanceMode;
     }
 
+    public static boolean isPerformanceMode() {
+        return performanceMode;
+    }
+
     private boolean castFaceDown = false;
 
     public Spell(final Card sourceCard, final Cost abCost) {