Pop-up warning when mobile client joins network draft/sealed lobby#10745
Open
MostCromulent wants to merge 2 commits into
Open
Pop-up warning when mobile client joins network draft/sealed lobby#10745MostCromulent wants to merge 2 commits into
MostCromulent wants to merge 2 commits into
Conversation
Online draft/sealed is desktop-only. Mobile users joining a Limited lobby didn't realise their client couldn't participate. Show a modal on the host and all clients when a libgdx client joins a Limited lobby, or when the host switches to Limited while libgdx clients are connected. Infrastructure: new LobbyAlertEvent + ILobbyListener.lobbyAlert with a cross-platform SOptionPane modal. TODO comments mark the mobile-specific trigger sites for removal once mobile supports online draft/sealed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@tool4ever I think this infrastructure is probably generally useful - might be worth extending the pop-up warnings to version mismatches as well since Discord suggests users often miss the version warning when its just posted to the chat window? |
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Resolve conflicts from the Card-Forge#10756 draft-event-handler refactor: keep the lobbyAlert feature on ILobbyListener and route LobbyAlertEvent to the lobby listener, while adopting master's IDraftEventHandler dispatch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Online draft/sealed shipped recently as desktop-only. Mobile users had no indication their client couldn't participate — they'd join a Limited lobby and end up confused with no draft UI.
Adds a modal that fires for the host and all clients when a libgdx client joins a Limited lobby, or when the host switches an existing lobby to Limited while libgdx clients are connected. New
LobbyAlertEvent+ILobbyListener.lobbyAlertplumbing reuses the existing event-dispatch path with a cross-platformSOptionPanemodal. TODO comments mark the mobile-specific trigger sites for removal once mobile supports online draft/sealed.🤖 Generated with Claude Code