Skip to content

CantHappen layer can stop iterating after finding one match! #11186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tool4ever merged 2 commits into from
Jul 8, 2026
+8 −6
Merged

CantHappen layer can stop iterating after finding one match! #11186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6a10e
CantHappen layer can stop iterating after finding one match!
Jul 8, 2026
e0fc5e5
CantHappen layer can stop iterating after finding one match!
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions forge-game/src/main/java/forge/game/replacement/ReplacementHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ public List<ReplacementEffect> getReplacementList(final ReplacementType event, f
&& replacementEffect.requirementsCheck(game)
&& replacementEffect.canReplace(runParams)) {
possibleReplacers.add(replacementEffect);
if (layer == ReplacementLayer.CantHappen) {
return false;
}
}
}
return true;
Expand Down
5 changes: 2 additions & 3 deletions forge-gui/res/cardsfolder/s/scarlet_witch_chaotic_avenger.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Types:Legendary Creature Mutant Warlock Hero
PT:3/3
K:Flying
T:Mode$ DamageDone | ValidSource$ Card.Self | ValidTarget$ Player | Execute$ TrigDig | CombatDamage$ True | TriggerDescription$ Whenever NICKNAME deals combat damage to a player, look at the top two cards of your library, then exile them face down. Then you may cast a Hero or noncreature spell from among cards exiled with NICKNAME without paying its mana cost.
SVar:TrigDig:DB$ Dig | DigNum$ 2 | ChangeNum$ All | DestinationZone$ Exile | ExileFaceDown$ True | WithMayLook$ True | RememberChanged$ True | SubAbility$ DBPlay
SVar:DBPlay:DB$ Play | ValidZone$ Exile | Valid$ Card.ExiledWithSource | ValidSA$ Spell.Hero,Spell.nonCreature | Controller$ You | WithoutManaCost$ True | Optional$ True | Amount$ 1 | SubAbility$ DBCleanup
SVar:DBCleanup:DB$ Cleanup | ClearRemembered$ True
SVar:TrigDig:DB$ Dig | DigNum$ 2 | ChangeNum$ All | DestinationZone$ Exile | ExileFaceDown$ True | WithMayLook$ True | SubAbility$ DBPlay
SVar:DBPlay:DB$ Play | ValidZone$ Exile | Valid$ Card.ExiledWithSource | ValidSA$ Spell.Hero,Spell.nonCreature | Controller$ You | WithoutManaCost$ True | Optional$ True | Amount$ 1
Oracle:Flying\nWhenever Scarlet Witch deals combat damage to a player, look at the top two cards of your library, then exile them face down. Then you may cast a Hero or noncreature spell from among cards exiled with Scarlet Witch without paying its mana cost.
6 changes: 3 additions & 3 deletions forge-gui/src/main/java/forge/gamemodes/match/AbstractGuiGame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public abstract class AbstractGuiGame implements IGuiGame, IMayViewCards {
private boolean ignoreConcedeChain = false;
private boolean networkGame = false;

private java.util.Timer waitingTimer;
private Timer waitingTimer;
private long waitingStartTime;

@Override
Expand Down Expand Up @@ -601,9 +601,9 @@ public void showWaitingTimer(final PlayerView forPlayer, final String waitingFor
}
this.waitingStartTime = System.currentTimeMillis();
// Capture timer so stale EDT tick runnables detect cancel/restart and skip
final java.util.Timer myTimer = new java.util.Timer("waitingTimer");
final Timer myTimer = new Timer("waitingTimer");
waitingTimer = myTimer;
myTimer.schedule(new java.util.TimerTask() {
myTimer.schedule(new TimerTask() {
@Override
public void run() {
FThreads.invokeInEdtLater(() -> {
Expand Down
Loading