Skip to content

Commit 020c9dd

Browse files
A0-4112: Increase MaxHolds to 50 (#1634)
# Description Polkadot has 50, and there are no practical implications to not increase it. In AlephNode 13 version, there are only two reasons for holds (`CodeUploadDeposit` and `StorageDeposit`), but in the future, there can be more, as more and more pallets are going to use holds and deprecate locks. Also, now we have `MaxLocks` == 50. ## Type of change Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) # Testing * make sure constant returned from wallet is 50 ![image](https://github.com/Cardinal-Cryptography/aleph-node/assets/3909333/87bbe71f-6391-42d6-8f81-1d07bf1fd474) * run adder e2e test: https://github.com/Cardinal-Cryptography/aleph-node/actions/runs/8062988259
1 parent 622a1f2 commit 020c9dd

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

bin/runtime/src/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,7 @@ impl pallet_authorship::Config for Runtime {
218218
parameter_types! {
219219
pub const ExistentialDeposit: u128 = 500 * PICO_AZERO;
220220
pub const MaxLocks: u32 = 50;
221-
// We have only 2 reasons for holds - CodeUploadDeposit and StorageDeposit.
222-
pub const MaxHolds: u32 = 2;
221+
pub const MaxHolds: u32 = 50;
223222
pub const MaxFreezes: u32 = 0;
224223
pub const MaxReserves: u32 = 50;
225224
}

0 commit comments

Comments
 (0)