Duotao/edit listing pane#179
Open
taoduo wants to merge 12 commits into
Open
Conversation
added 12 commits
September 7, 2016 15:06
Member
|
Hey Duo, thanks for all your work on this. It's a little late for me right now but I'll take a deeper look tomorrow. |
Author
|
Hey Joe, yeah this is kind of complicated. If you can come up with a neater solution, it will be awesome. That said, this works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated the listing edit pane.
Solved the problem by adding a pane under each listing and show the pane upon click.
Made some changes to CSS when I need to move the edit pane, including the cancel button from tfoot to tbody.
This may not be the best practice but works.