Skip to content

Commit 1969bd9

Browse files
committed
add comment about pooling logic
1 parent 6619a08 commit 1969bd9

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

backend/packages/Upgrade/src/api/controllers/ExperimentController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import { env } from '../../env';
3030
import { NotFoundException } from '@nestjs/common/exceptions';
3131
import { ExperimentIdValidator } from '../DTO/ExperimentDTO';
3232
import { ImportExportService } from '../services/ImportExportService';
33-
import { SUPPORTED_MOOCLET_ALGORITHMS } from 'types/src';
33+
import { SUPPORTED_MOOCLET_ALGORITHMS } from 'upgrade_types';
3434

3535
interface ExperimentPaginationInfo extends PaginationResponse {
3636
filtered: number;

backend/packages/Upgrade/src/api/services/MoocletRewardsService.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ export class MoocletRewardsService {
167167
);
168168
}
169169

170+
// TODO: this is a spot where we want to use shared-decision-point pooling logic,
171+
// but for now if there are competing experiments, it will be required to use experimentId
170172
if (moocletExperimentRefs.length > 1) {
171173
this.throwConflictError(
172174
`Multiple active experiments found for decision point (context: ${context}, site: ${site}, target: ${target}), cannot determine which to send reward to.`

0 commit comments

Comments
 (0)