fix typos and test error usage

Author: danoswaltCL

backend/packages/Upgrade/src/api/services/MoocletRewardsService.ts

@@ -107,7 +107,7 @@ export class MoocletRewardsService {
       // NOTE: in the future we may want to batch these, the mooclet API technically supports it by adding "/create_many" to an endpoint but it's not documented
       this.moocletDataService.postNewReward(reward, logger);
 
-      return { message: `Reward sent to mooclet successfuly.`, request: this.request, reward };
+      return { message: `Reward sent to mooclet successfully.`, request: this.request, reward };
     } catch (error) {
       if (error instanceof HttpError) {
         throw error;
@@ -186,7 +186,7 @@ export class MoocletRewardsService {
       (map) => enrollment.conditionId === map.experimentConditionId
     );
     if (!map) {
-      this.throwConflictError(`Version-condtiion mapping not found, no reward sent.`);
+      this.throwConflictError(`Version-condition mapping not found, no reward sent.`);
     }
     return map.moocletVersionId;
   }
@@ -197,9 +197,8 @@ export class MoocletRewardsService {
   private throwConflictError(message: string): never {
     this.logger.error({ message, request: this.request });
 
-    const error = new Error(message);
+    const error = new HttpError(409, message);
     (error as any).type = SERVER_ERROR.MOOCLET_REWARD_ERROR;
-    (error as any).httpCode = 409;
     throw error;
   }
 }

backend/packages/Upgrade/test/unit/services/MoocletRewardsService.test.ts

@@ -107,7 +107,7 @@ describe('MoocletRewardsService', () => {
 
         const result = await service.sendReward(mockUser, request, mockLogger as any);
 
-        expect(result.message).toBe('Reward sent to mooclet successfuly.');
+        expect(result.message).toBe('Reward sent to mooclet successfully.');
         expect(result.reward).toEqual({
           variable: 'reward_variable',
           value: 1,
@@ -137,7 +137,7 @@ describe('MoocletRewardsService', () => {
 
         const result = await service.sendReward(mockUser, request, mockLogger as any);
 
-        expect(result.message).toBe('Reward sent to mooclet successfuly.');
+        expect(result.message).toBe('Reward sent to mooclet successfully.');
         expect(result.reward.value).toBe(0); // FAILURE maps to 0
         expect(mockMoocletDataService.postNewReward).toHaveBeenCalledTimes(1);
       });
@@ -209,7 +209,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('No active mooclet experiment ref found');
+          expect((error as HttpError).message).toContain('No active mooclet experiment ref found');
         }
       });
 
@@ -234,7 +234,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('No active experiment found for decision point');
+          expect((error as HttpError).message).toContain('No active experiment found for decision point');
         }
       });
 
@@ -262,7 +262,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('Multiple active experiments found for decision point');
+          expect((error as HttpError).message).toContain('Multiple active experiments found for decision point');
         }
       });
 
@@ -290,7 +290,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('not actively enrolling');
+          expect((error as HttpError).message).toContain('not actively enrolling');
         }
       });
     });
@@ -337,7 +337,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('Could not find unique user enrollment');
+          expect((error as HttpError).message).toContain('Could not find unique user enrollment');
         }
       });
 
@@ -354,7 +354,7 @@ describe('MoocletRewardsService', () => {
 
         const result = await service.sendReward(mockUser, request, mockLogger as any);
 
-        expect(result.message).toBe('Reward sent to mooclet successfuly.');
+        expect(result.message).toBe('Reward sent to mooclet successfully.');
       });
     });
 
@@ -383,7 +383,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('Version-condtion mapping not found');
+          expect((error as HttpError).message).toContain('Version-condition mapping not found');
         }
       });
 
@@ -428,7 +428,7 @@ describe('MoocletRewardsService', () => {
           await service.sendReward(mockUser, request, mockLogger as any);
         } catch (error) {
           expect((error as HttpError).httpCode).toBe(409);
-          expect((error as Error).message).toContain('Failed to process reward request due to unexpected error');
+          expect((error as HttpError).message).toContain('Failed to process reward request due to unexpected error');
         }
       });
 
@@ -557,7 +557,7 @@ describe('MoocletRewardsService', () => {
         const result = await service.sendReward(mockUser, request, mockLogger as any);
 
         expect(mockMoocletExperimentRefRepository.findOne).toHaveBeenCalledTimes(1);
-        expect(result.message).toBe('Reward sent to mooclet successfuly.');
+        expect(result.message).toBe('Reward sent to mooclet successfully.');
       });
 
       it('should query with correct relations', async () => {