Skip to content

Commit c3e94e1

Browse files
committed
add experimentId to some of the rawjson saves for logs that are missing it so we can fully query by experimentId
1 parent 266e07d commit c3e94e1

4 files changed

Lines changed: 16 additions & 2 deletions

File tree

packages/backend/src/api/services/AnalyticsService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,7 @@ export class AnalyticsService {
529529
}
530530
await this.experimentAuditLogRepository.saveRawJson(
531531
LOG_TYPE.EXPERIMENT_DATA_EXPORTED,
532-
{ experimentName: experimentDetails[0].experimentName },
532+
{ experimentId: experimentDetails[0].experimentId, experimentName: experimentDetails[0].experimentName },
533533
user
534534
);
535535
logger.info({ message: `Exported Data emailed successfully to ${email}` });

packages/backend/src/api/services/ExperimentService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@ export class ExperimentService {
351351

352352
// adding entry in audit log
353353
const deleteAuditLogData = {
354+
experimentId: experiment.id,
354355
experimentName: experiment.name,
355356
};
356357

packages/backend/src/api/services/ImportExportService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class ImportExportService {
135135

136136
this.experimentAuditLogRepository.saveRawJson(
137137
LOG_TYPE.EXPERIMENT_DESIGN_EXPORTED,
138-
{ experimentName: experiment.name },
138+
{ experimentId: experiment.id, experimentName: experiment.name },
139139
user
140140
);
141141
return experimentRecord;

packages/types/src/Experiment/interfaces.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,17 @@ interface ExperimentStateChangedData {
8585
}
8686

8787
interface ExperimentDeletedData {
88+
experimentId: string;
89+
experimentName: string;
90+
}
91+
92+
interface ExperimentDataExportedData {
93+
experimentId: string;
94+
experimentName: string;
95+
}
96+
97+
interface ExperimentDesignExportedData {
98+
experimentId: string;
8899
experimentName: string;
89100
}
90101

@@ -126,6 +137,8 @@ export type AuditLogData =
126137
| ExperimentUpdatedData
127138
| ExperimentStateChangedData
128139
| ExperimentDeletedData
140+
| ExperimentDataExportedData
141+
| ExperimentDesignExportedData
129142
| FeatureFlagCreatedData
130143
| FeatureFlagUpdatedData
131144
| FeatureFlagStateChangedData

0 commit comments

Comments
 (0)