Skip to content

Fix duplicate experiment row after first experiment creation #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackcl merged 1 commit into from
Jun 11, 2026
Merged

Fix duplicate experiment row after first experiment creation #3174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ const reducer = createReducer(
on(experimentsAction.actionUpsertExperiment, experimentsAction.actionGetExperimentById, (state) => ({
...state,
isLoadingExperiment: true,
// if we don't have a totalExperiments count yet (no paginated call with > 1 has occured yet),
// set it to 1 because we are loading at least one experiment so that nav to root page will not show empty template
totalExperiments: state.totalExperiments ? state.totalExperiments : 1,
// If the total count is unknown, assume at least one experiment is loading so the root page skips the empty state.
// Preserve 0 because it means the backend already confirmed an empty list.
totalExperiments: state.totalExperiments ?? 1,
Comment thread
zackcl marked this conversation as resolved.
})),
on(experimentsAction.actionGetExperimentByIdSuccess, (state, { experiment }) => {
// Upsert experiment: update if exists, add if not (for direct navigation)
Expand Down
Loading