Use arel for joining with rank table#576
Open
fatkodima wants to merge 1 commit into
Open
Conversation
chaadow
reviewed
Jun 27, 2026
| def rank_join(rank_table_alias) | ||
| "INNER JOIN (#{subquery.to_sql}) AS #{rank_table_alias} ON #{primary_key} = #{rank_table_alias}.pg_search_id" | ||
| arel_table = model.arel_table | ||
| alias_arel_table = Arel::Table.new(rank_table_alias) |
There was a problem hiding this comment.
Is it possible to make this conditional to support rails main. Because recently Arel::Table was changed to accept keyword arguments
and I won't be able to use your fix on my production app, as well as it won't be compatible for future rails versions.
thanks ( PR link )
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks! Was able to make it simpler and don't create arel table explicitly.
fatkodima
force-pushed
the
use-arel-joins
branch
from
81f8dcf to
b45ff2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206.
We faced the same problem as described in the linked issue - when active record creates an alias for one of the tables (the table for the top model or one of the joined tables) and the SQL query become invalid when trying to order or group etc.
The problem is here https://github.com/rails/rails/blob/d5afe4f6811c60dc1400c90624a1bbf77c572da6/activerecord/lib/active_record/associations/alias_tracker.rb#L33-L44
When passing a string JOIN, active record simply grep matches it to decide if aliases are needed, for safety. But when passing arel, it can make smarter decisions.