Better support for ECDSA signatures in ABI arguments#319
Merged
rkalis merged 8 commits intoCashScript:v0.12-releasefrom Sep 23, 2025
Merged
Better support for ECDSA signatures in ABI arguments#319rkalis merged 8 commits intoCashScript:v0.12-releasefrom
rkalis merged 8 commits intoCashScript:v0.12-releasefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mainnet-pat
force-pushed
the
argument_ecdsa
branch
from
14d614b to
f9f5958
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 97.35% 97.42% +0.07%
==========================================
Files 76 78 +2
Lines 17440 17970 +530
Branches 1274 1349 +75
==========================================
+ Hits 16978 17508 +530
- Misses 455 456 +1
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mainnet-pat
force-pushed
the
argument_ecdsa
branch
from
f9f5958 to
252ec71
Compare
Contributor
Author
|
Had a rare case where an ECDSA signature was 70 bytes long. included in most recent commit |
mainnet-pat
force-pushed
the
argument_ecdsa
branch
from
2648ec8 to
0ebac8c
Compare
Member
|
Thanks again for the contribution @mainnet-pat! We've made some small changes to the tests, and will now merge this PR. It will be included in v0.12. |
rkalis
added a commit
that referenced
this pull request
Oct 2, 2025
Co-authored-by: Rosco Kalis <roscokalis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not fail to accept ECDSA tx signatures and data signatures