Question about the reference jar

[defaultax7]

I have downloaded the latest version of the Jar and did some testing with the following input.

map01.map

5
######
#.Aa@#
#B...#
#b...#
#@...#
######

Action0.txt

0
L
L
J
E

Action1.txt

1
J
K
K
E

First, I try it with
java --enable-preview -jar Sokoban-proguard-PA3.jar 1 map01.map ROUND_ROBIN 60 actions/actions0.txt actions/actions1.txt
As it is round-robin, player0 first move the box to destination and player1 followed to push his box to the destination.
The game should be win and as #203 stated, no more action should be processed.
But, I get this. Both players still move after the game is win

I have also used the same set of testing material and try to run more in parallel.
As more ReplaySokobanGame run in parallel, the program have higher chance to stuck.
For example, I run this
java --enable-preview -jar Sokoban-proguard-PA3.jar 20 map01.map ROUND_ROBIN 60 actions/actions0.txt actions/actions1.txt
The program stuck. Nothing is printing and it consumes almost 100% of my CPU.
I have changed it to FREE_RACE and the same also happened.

I have tried the given test case in README
java --enable-preview -jar Sokoban-proguard-PA3.jar 3 src/main/resources/map02.map ROUND_ROBIN 100 src/main/resources/actions/actions0.txt src/main/resources/actions/actions1.txt
And increase the number to run in parallel. When I set it to 100, the program still finish quickly.
When I set it to 1000, the program seems to never end but there are still something printing on the screen and my CPU usage is around 20%.

I just want to ask, it is expected behavior?

[Troublor]

😳 Well, I confirm this is a bug. This is not an expected behavior. Will fix this today.

[Troublor]

Should be fixed. Please try with the latest reference implementation.

[herwei255]

With java --enable-preview -jar Sokoban-proguard-PA3.jar 1 map01.map ROUND_ROBIN 60 actions/actions0.txt actions/actions1.txt, the output is shown below with the new reference implementation.

However, shouldn't the game be won after 0: L, 1: J ...
And thus, further actions shouldn't be processed, which means 'Failed to push the box' should not be shown?

Another question is, do we have to implement the printing out of 'Game exits.' and 'You win.'?

[Troublor]

Another question is, do we have to implement the printing out of 'Game exits.' and 'You win.'?

Printing things on the console is not a must. You don't have to.

[Troublor]

@herwei255 Sorry that I mistakenly delete your message. You may be right. Let me check the reference implementation once more.

[Troublor]

@herwei255 You are right. There shouldn't be a Failed to push the box message.
This is due to a read-write race in reference implementation, when input engine B is still processing action 1:J while the input engine A reads the game state preemptively.
I have fixed the problem and published a new reference implementation jar.