Notify attribute does not show initial values in inspector window

[valkyrienyanko]

Version

Cat Lips Source Generators: 2.7.0-260308-1543.Release
Godot: v4.6.1.stable.mono.official [14d19694e]
Net 10.0 C# 13

Problem

The [Notify] attribute is not showing the set initial values in the editors inspector window. This is making it hard to change the value in-game based off the default value set from script.

Script

Inspector Window

Trying to set initial value directly

Note that if the value is set directly (without the [Notify] attribute) then the initial value can be seen just fine in the inspector.

[Cat-Lips]

Yes, that is an unfortunate limitation of the language. Short of adding a string representation of the default value as an attribute property, you'll have to add default values in the constructor when using partial properties. Hopefully the editor still will pick that up as the default.

[valkyrienyanko]

Setting them explicitly in the constructor e.g. DetectionRadius = 150; does not show up in editor.

I've opened up a PR (#181) that allows you to set the property value directly without any need for a constructor. I've tested this and the value shows up correctly in the editor. For example we can now do

[Notify] [Export] public partial float DetectionRadius { get; private set; } = 150;

[Cat-Lips]

Oh wow, now I see it - As long as we use 'field' in get/set we can use the initialiser!

So it looks like even this will work:

[Export, Notify] public int NonPartialInlineDefault { get => field = _nonPartialInlineDefault.Get(); set => _nonPartialInlineDefault.Set(field = value); } = 7;

That has been an ick-point for a very long time. Nice job finding the fix!

[valkyrienyanko]

@Cat-Lips I just tested latest release and I'm getting null reference assignment warning. I think the null forgiving operator needs to be added to either _value = value!; right after OnDataChanging(); or added to _{{Field}}.Set(field = value!); because I've done this in my PR and the warning went away.

My code is mostly unchanged since last test. Notice not all these members have initial values set to them so they need to be null forgiven.

[Cat-Lips]

I would have thought this line would have triggered the warning:

[Notify] public partial string NotifyTestUsingPartial { get; set; }

Any idea why it didn't?

EDIT:

Also, assuming you're using NRT, you might want the warning to show up. You'd have to declare it as Shape2D? if you wanted it to be nullable. (If you're not using NRT, then if we hide it, it will also be hidden for those that might want the warning.)

[valkyrienyanko]

I'm not using NRT. Maybe the source gen could check if NRT was enabled and generate based off that?

I probably should just enable NRT, but at the same time I don't want to because then I would have to address an explosion of nullable warnings everywhere else which to be fair I probably should address but I just don't want to at the moment lol.

But yeah if NRT was enabled then it would definitely generate the warning at that line and then I would just add = null!