Skip to content

Commit 65dac4f

Browse files
committed
test: align fixtures with rebased anonymous-suggestion model and class-detail query
Two pre-existing tests on upstream/main exercise code paths that this PR's commits modify. After rebasing onto upstream/main, fixtures need to reflect the new model fields and an additional db.execute call: - _make_session() in test_suggestion_service.py: explicitly default is_anonymous=False, submitter_name=None, submitter_email=None so MagicMock(spec=SuggestionSession) doesn't auto-generate truthy MagicMock attrs that drive the new anonymous branch in _build_summary. - TestGetClassDetail / TestGetClassDetailAnnotations: add a 7th side_effect entry for the new IndexedLabel query introduced by "fix: include translations and synonyms in index path class detail". Also drops a now-unused import in test_auth_disabled.py flagged by ruff.
1 parent 2392683 commit 65dac4f

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

tests/unit/test_auth_disabled.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
get_current_user_with_token,
1414
)
1515

16-
1716
# ---------------------------------------------------------------------------
1817
# ANONYMOUS_USER constant
1918
# ---------------------------------------------------------------------------

tests/unit/test_ontology_index_service.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ async def test_get_class_detail_found(
451451
mock_entity_result = MagicMock()
452452
mock_entity_result.scalar_one_or_none.return_value = entity
453453

454-
# labels, comments, parents, child_count, annotations
454+
# labels, comments, parents, child_count, annotations, non-rdfs labels
455455
mock_labels = MagicMock()
456456
mock_labels.scalars.return_value.all.return_value = []
457457
mock_comments = MagicMock()
@@ -462,6 +462,8 @@ async def test_get_class_detail_found(
462462
mock_child_count.scalar.return_value = 0
463463
mock_annotations = MagicMock()
464464
mock_annotations.scalars.return_value.all.return_value = []
465+
mock_non_rdfs_labels = MagicMock()
466+
mock_non_rdfs_labels.scalars.return_value.all.return_value = []
465467

466468
mock_db.execute.side_effect = [
467469
mock_entity_result,
@@ -470,6 +472,7 @@ async def test_get_class_detail_found(
470472
mock_parents,
471473
mock_child_count,
472474
mock_annotations,
475+
mock_non_rdfs_labels,
473476
]
474477

475478
result = await service.get_class_detail(PROJECT_ID, BRANCH, "http://example.org/Person")
@@ -539,6 +542,10 @@ async def test_get_class_detail_with_labels_and_parents(
539542
mock_annotations = MagicMock()
540543
mock_annotations.scalars.return_value.all.return_value = []
541544

545+
# Non-rdfs:label entries (translations/synonyms via skos:altLabel etc.)
546+
mock_non_rdfs_labels = MagicMock()
547+
mock_non_rdfs_labels.scalars.return_value.all.return_value = []
548+
542549
mock_db.execute.side_effect = [
543550
mock_entity_result,
544551
mock_labels,
@@ -548,6 +555,7 @@ async def test_get_class_detail_with_labels_and_parents(
548555
mock_parent_labels,
549556
mock_child_count,
550557
mock_annotations,
558+
mock_non_rdfs_labels,
551559
]
552560

553561
result = await service.get_class_detail(PROJECT_ID, BRANCH, "http://example.org/Person")
@@ -883,13 +891,18 @@ async def test_get_class_detail_with_annotations(
883891
mock_annotations = MagicMock()
884892
mock_annotations.scalars.return_value.all.return_value = [ann]
885893

894+
# Non-rdfs:label entries (translations/synonyms via skos:altLabel etc.)
895+
mock_non_rdfs_labels = MagicMock()
896+
mock_non_rdfs_labels.scalars.return_value.all.return_value = []
897+
886898
mock_db.execute.side_effect = [
887899
mock_entity_result,
888900
mock_labels,
889901
mock_comments,
890902
mock_parents,
891903
mock_child_count,
892904
mock_annotations,
905+
mock_non_rdfs_labels,
893906
]
894907

895908
result = await service.get_class_detail(PROJECT_ID, BRANCH, "http://example.org/Thing")

tests/unit/test_suggestion_service.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ def _make_session(
7979
session.summary = None
8080
session.created_at = datetime.now(UTC)
8181
session.last_activity = last_activity or datetime.now(UTC)
82+
# Anonymous-suggestion fields default to non-anonymous for existing tests.
83+
session.is_anonymous = False
84+
session.submitter_name = None
85+
session.submitter_email = None
8286
return session
8387

8488

0 commit comments

Comments
 (0)