Fix #1

Author: CaveNightingale

src/main/java/wearblackallday/dimthread/mixin/EntityMixin.java

@@ -104,23 +104,25 @@ public void onMoveToWorld(ServerWorld destination, CallbackInfoReturnable<Entity
 			return;
 
 		if (DimThread.owns(Thread.currentThread())) {
-			nbtCachedForMoveToWorld = writeNbt(new NbtCompound());
-			uncompletedTeleportTargetForMoveToWorld = createTeleportTargetUncompleted(destination);
-			destination.getServer().execute(
-					() -> {
-						Entity entity = this.moveToWorld(destination);
-						if(entity == null) {
-							this.unsetRemoved();
-							nbtCachedForMoveToWorld.putInt("PortalCooldown", this.netherPortalCooldown);
-							this.readNbt(nbtCachedForMoveToWorld);
-							this.uncompletedTeleportTargetForMoveToWorld = null;
-							this.nbtCachedForMoveToWorld = null;
-							this.world.spawnEntity((Entity) (Object) this);// if the teleporting failed, we need to add it back to the world
-							LOGGER.debug("Failed to teleport {}, return it to its previous world", this);
+			if (nbtCachedForMoveToWorld == null) { // Some entity may invoke moveToWorld many times, which may cause https://github.com/CaveNightingale/DimensionalThreading/issues/1
+				nbtCachedForMoveToWorld = writeNbt(new NbtCompound());
+				uncompletedTeleportTargetForMoveToWorld = createTeleportTargetUncompleted(destination);
+				destination.getServer().execute(
+						() -> {
+							Entity entity = this.moveToWorld(destination);
+							if (entity == null) {
+								this.unsetRemoved();
+								nbtCachedForMoveToWorld.putInt("PortalCooldown", this.netherPortalCooldown);
+								this.readNbt(nbtCachedForMoveToWorld);
+								this.uncompletedTeleportTargetForMoveToWorld = null;
+								this.nbtCachedForMoveToWorld = null;
+								this.world.spawnEntity((Entity) (Object) this);// if the teleporting failed, we need to add it back to the world
+								LOGGER.debug("Failed to teleport {}, return it to its previous world", this);
+							}
 						}
-					}
-			);
-			this.removeFromDimension();
+				);
+				this.removeFromDimension();
+			}
 			ci.setReturnValue(null);
 		}
 	}

src/main/java/wearblackallday/dimthread/mixin/PerfCommandMixin.java

@@ -0,0 +1,20 @@
+package wearblackallday.dimthread.mixin;
+
+import com.mojang.brigadier.CommandDispatcher;
+import net.minecraft.server.command.ServerCommandSource;
+import net.minecraft.server.dedicated.command.PerfCommand;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Inject;
+import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
+
+@Mixin(PerfCommand.class)
+public abstract class PerfCommandMixin {
+	/**
+	 * Remove /perf because it's not thread-safe
+	 */
+	@Inject(method = "register", at = @At("HEAD"), cancellable = true)
+	private static void removePerfCommand(CommandDispatcher<ServerCommandSource> dispatcher, CallbackInfo ci) {
+		ci.cancel();
+	}
+}

src/main/resources/dimthread.mixins.json

@@ -7,6 +7,7 @@
     "EntityMixin",
     "MinecraftDedicatedServerMixin",
     "MinecraftServerMixin",
+    "PerfCommandMixin",
     "RedstoneWireBlockMixin",
     "ServerChunkManagerMixin",
     "ServerWorldMixin",