-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add sub-section support for pages #2321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8e3c786
28702da
5c4cbbd
afdaec0
6e5dcbd
2d394df
48174c6
8308c11
25c51e5
361b72e
36694c9
4f931bb
9831754
90bcab8
0aac27b
731f721
edcaf67
9c560a5
8e7576d
89113d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,9 @@ | |
| <testsuite name="IntegrationCliTests"> | ||
| <file>./tests/IntegrationCliTests.php</file> | ||
| </testsuite> | ||
| <testsuite name="SubSectionTests"> | ||
| <file>./tests/SubSectionTests.php</file> | ||
| </testsuite> | ||
|
Comment on lines
+33
to
+35
|
||
| </testsuites> | ||
| <coverage includeUncoveredFiles="false"></coverage> | ||
| </phpunit> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation states that
page.subsectionsandpage.parentcan be accessed as page variables. However, Twig's property access forpage.subsectionswill try to callgetSubsections()(lowercase 's'), but the actual method isgetSubSections()(camelCase with capital 'S'). Similarly,page.parentwill trygetParent()but the method isgetParentSection(). Users should use the Twig functionssubsections(page)andparent_section(page)instead, or the documentation should be updated to reflect the correct property accessors.