refactor(core): overhaul method id generation and improve patcher stability

- rewrite MonoModExtensions.GetIdentifier with generic/anonymous-type edge-case handling
- harden NetworkLogicPruner EH pruning and add regression tests
- add thread-local/sections reset patches and update GlobalNetwork runtime wiring

Author: CedaryCat

src/OTAPI.UnifiedServerProcess.GlobalNetwork/CommandHandler.cs

@@ -21,7 +21,7 @@ public class CommandHandler
         public CommandHandler(Router router, ChatHandler chat) {
             this.router = router;
             On.Terraria.Chat.Commands.SayChatCommand.ProcessIncomingMessage += ProcessIncomingMessage;
-            On.OTAPI.HooksSystemContext.MainSystemContext.InvokeCommandProcess += ProcessConsoleMessage;
+            On.OTAPI.HooksSystemContext.MainSystemContext.InvokeCommandProcess_string_string += ProcessConsoleMessage;
         }
 
         public void KeepReadingInput() {
@@ -39,7 +39,7 @@ void ProcessIncomingMessage(On.Terraria.Chat.Commands.SayChatCommand.orig_Proces
 
             orig(self, root, text, clientId);
         }
-        bool ProcessConsoleMessage(On.OTAPI.HooksSystemContext.MainSystemContext.orig_InvokeCommandProcess orig, HooksSystemContext.MainSystemContext self,
+        bool ProcessConsoleMessage(On.OTAPI.HooksSystemContext.MainSystemContext.orig_InvokeCommandProcess_string_string orig, HooksSystemContext.MainSystemContext self,
             string lowered, string raw) {
 
             if (ProcessUSPCommandText(self.root, raw, byte.MaxValue)) {

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Network/NetworkPatcher.cs

@@ -23,7 +23,6 @@ private static void Modified_StartServer(On.Terraria.NetplaySystemContext.orig_S
 
             var Main = server.Main;
 
-            Terraria.Main.rand ??= new UnifiedRandom((int)DateTime.Now.Ticks);
             self.ServerIP = IPAddress.Any;
             Main.menuMode = 14;
             Main.statusText = Lang.menu[8].Value;

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Network/Router.cs

@@ -340,7 +340,7 @@ public void ServerWarp(byte plr, ServerContext to) {
                 activePlayer.active = true;
 
                 SetClientCurrentlyServer(plr, to);
-                client.ResetSections(to);
+                client.mfwh_ResetSections(to);
 
                 SyncHelper.SyncServerOnlineToPlayer(to, plr);
                 SyncHelper.SyncPlayerJoinToOthers(to, plr);

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Network/SyncHelper.cs

@@ -68,9 +68,6 @@ static void SendWorldEntities(this ServerContext server, int whoAmI) {
             }
         }
         static void SendWorldInfo(this ServerContext server, int whoAmI) {
-            for (int i = 0; i < 290; i++) {
-                server.NetMessage.TrySendData(MessageID.NPCKillCountDeathTally, whoAmI, -1, null, i);
-            }
             server.NetMessage.TrySendData(57, whoAmI);
             server.NetMessage.TrySendData(MessageID.MoonlordHorror);
             server.NetMessage.TrySendData(MessageID.UpdateTowerShieldStrengths, whoAmI);
@@ -112,7 +109,7 @@ public static void SyncServerOfflineToPlayer(ServerContext offlineServer, int pl
                 if (!item.active || item.playerIndexTheItemIsReservedFor != plr) {
                     continue;
                 }
-                SendSmallPacket(offlineServer, plr, new ItemOwner((short)i, 255));
+                SendSmallPacket(offlineServer, plr, new ItemOwner((short)i, 255, item.position));
             }
             for (int i = 0; i < Terraria.Main.maxProjectiles; i++) {
                 var proj = offlineServer.Main.projectile[i];

src/OTAPI.UnifiedServerProcess.GlobalNetwork/OTAPI.UnifiedServerProcess.GlobalNetwork.csproj

@@ -10,9 +10,10 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="MonoMod.RuntimeDetour" Version="25.2.3" />
+		<PackageReference Include="MonoMod.RuntimeDetour" Version="25.3.3" />
 		<PackageReference Include="MonoMod.RuntimeDetour.HookGen" Version="22.7.31.1" />
-		<PackageReference Include="ModFramework.Modules.CSharp" Version="1.1.15" />
+		<PackageReference Include="ModFramework.Modules.CSharp" Version="1.1.16" />
+		<PackageReference Include="System.IO.Packaging" Version="10.0.2" />
 	</ItemGroup>
 	<ItemGroup>
 		<Reference Include="OTAPI">

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Program.cs

@@ -44,12 +44,8 @@ static void Main(string[] args) {
 
             WorkRunner.RunTimedWorkAsync("Starting main servers...",
             () => {
-                Task.Run(() => {
-                    server1.Program.LaunchGame(args);
-                });
-                Task.Run(() => {
-                    server2.Program.LaunchGame(args);
-                });
+                server1.Run(args);
+                server2.Run(args);
                 var tcs = new TaskCompletionSource();
                 router.Started += () => tcs.SetResult();
                 return tcs;

src/OTAPI.UnifiedServerProcess.GlobalNetwork/Servers/ServerContext.cs

@@ -19,6 +19,21 @@ public ServerContext(string worldName, byte[] worldFileData) : base(worldName) {
             Netplay.ListenPort = -1;
             Netplay.UseUPNP = true;
         }
+        public Thread? RunningThread { get; protected set; }
+        public virtual Thread Run(string[] args) {
+            Thread result = RunningThread = new Thread(() => RunBlocking(args)) {
+                IsBackground = true,
+            };
+            result.Name = $"Server Instance: {Name}";
+            result.Start();
+            return result;
+        }
+        public virtual void RunBlocking(string[] args) {
+            ThreadLocalInitializer.Initialize();
+            RunningThread = Thread.CurrentThread;
+            RunningThread.Name = $"Server Instance: {Name}";
+            Program.LaunchGame(args);
+        }
         public override string ToString() => $"{{ Type:ServerContext, Name:\"{Name}\", Players:{Main.player.Count(p => p.active)} }}";
     }
 }

src/OTAPI.UnifiedServerProcess.UnitTests/DelegatePlaceholderProcessorByRefTests.cs

@@ -4,6 +4,8 @@
 using OTAPI.UnifiedServerProcess.Core;
 using OTAPI.UnifiedServerProcess.Core.FunctionalFeatures;
 using OTAPI.UnifiedServerProcess.Core.Patching.FieldFilterPatching;
+using OTAPI.UnifiedServerProcess.Core.Patching.GeneralPatching;
+using OTAPI.UnifiedServerProcess.Core.Patching.GeneralPatching.Arguments;
 using OTAPI.UnifiedServerProcess.Loggers;
 using System;
 using System.IO;
@@ -113,8 +115,8 @@ public void Apply_PropagatesDelegateRewriteThroughByRefFieldAndLocalAddresses()
             host.Methods.Add(callerLocalByRef);
 
             var analyzers = new AnalyzerGroups(new NullLogger(), module);
-            var processor = new DelegatePlaceholderProcessor(rootContextDef, analyzers);
-            var source = new FilterArgumentSource(module, []);
+            var processor = new DelegatePlaceholderProcessor(analyzers);
+            var source = new PatcherArgumentSource(module, rootContextDef);
 
             processor.Apply(new TestComponent(new NullLogger()), ref source);
             processor.ClearJumpSitesCache();